-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect duplicate code errors #314
Merged
phackstock
merged 10 commits into
IAMconsortium:main
from
phackstock:feature/collect-duplicate-code-errors
Jan 24, 2024
Merged
Collect duplicate code errors #314
phackstock
merged 10 commits into
IAMconsortium:main
from
phackstock:feature/collect-duplicate-code-errors
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e982308
to
31bc11c
Compare
danielhuppmann
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104, closes #312.
Instead of reporting duplicate code errors one by one we now collect them and raise them as one single error. For better readability the individual errors are indented and numbered.
From previously reporting:
ValueError: Duplicate item in variable codelist: Secondary Energy|Liquids
we now have:
Update 24.01.2024 10:09
Since IAMconsortium/legacy-definitions#1 has already been resolved, I had to also address #311.
The current way the test
test_multiple_external_repos
is configured is not the most elegant way but it should be ok.It tests for the following:
The reason I opted for 3. instead of testing for the presence of specific variables is that we expect to migrate variables from legacy to common definitions. This way it could happen that at some point all the variables that I would test for to prove that both legacy and common definitions are imported are now wholly in common-definitions.
That's why I opted to check for the overall size of the code list. Also not 100% future proof but good enough for now I'd say.