Use multiple external repos for definitions and mappings #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we're having some Windows issues... I hope I can resolve them quickly. |
| return {v} | ||
| case list(v): | ||
| return set(v) | ||
| case set(v): |
There was a problem hiding this comment.
Do we want to allow a set type?
There was a problem hiding this comment.
We want to cast to set ultimately. If the user already provides a set we just pass it through. This case is pretty rare though since we usually create our NomenClatureConfig from a yaml file so the input value there will always be a string or a list of strings.
For clarity I should switch the order though.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295, closes #313.
This PR allows for using multiple external repos combined in a single dimension.
The complete test I implemented for that pulls from common-definitions and legacy-definitions.
Since legacy-definitions currently contains duplicates from common-definitions initiating a CodeList will result in an error. The test tests for this error.
Once this PR is merged, I'll do the following:
All of that should be possible today.