-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage #310
Merged
phackstock
merged 18 commits into
IAMconsortium:main
from
phackstock:feature/improve-test-coverage
Jan 22, 2024
Merged
Improve test coverage #310
phackstock
merged 18 commits into
IAMconsortium:main
from
phackstock:feature/improve-test-coverage
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhuppmann
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion in the docstring, otherwise good to go - and nice work!
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309.
Changes implemented
Added tests
the remaining few percent I deemed either not necessary to test or point to potentially unused code which I didn't want to touch for this PR.
parse_model_registration
Aligned CLI with standards
--dimensions [one, two]
to--dimensions one --dimensions two
. This is now in line with cli standards.Made the setitem method of CodeList more robust
Code
and if the key and the code name are identicalClean up config
NomenclatureConfig
.local_path