-
Notifications
You must be signed in to change notification settings - Fork 678
Comparing changes
Open a pull request
base repository: woowacourse-precourse/javascript-racingcar-6
base: main
head repository: Hys-Lee/javascript-racingcar-6
compare: main
- 16 commits
- 5 files changed
- 1 contributor
Commits on Oct 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 641407b - Browse repository at this point
Copy the full SHA 641407bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0719ce5 - Browse repository at this point
Copy the full SHA 0719ce5View commit details -
Feat: handling a input for car names
made function seperateCarNames from utils/inputHandling.js for checking valid car names
Configuration menu - View commit details
-
Copy full SHA for 904a1f6 - Browse repository at this point
Copy the full SHA 904a1f6View commit details -
Feat: input handling for trial number
checked whether input is integer greater and equal than 0 it would throw error for execption cases. get trial number as private property because it will only used in App class get car names as public property for now. it could be changed to private one.
Configuration menu - View commit details
-
Copy full SHA for 2c4575b - Browse repository at this point
Copy the full SHA 2c4575bView commit details -
it has 2 properties, which are name and the number of movements when the random number is greater and equal than 4 represented as the number of dash. it also has 2 methods, which are for getting random number and checking movements and printing all dashes of the current car.
Configuration menu - View commit details
-
Copy full SHA for df10473 - Browse repository at this point
Copy the full SHA df10473View commit details -
Configuration menu - View commit details
-
Copy full SHA for f10cf3a - Browse repository at this point
Copy the full SHA f10cf3aView commit details -
Feat: filter and get winners who have the highest number of movement
resulting and other steps are seperated into methods. got the maximum number of movements from all cars and comparing all cars to find one having maximum movements.
Configuration menu - View commit details
-
Copy full SHA for 1efd43d - Browse repository at this point
Copy the full SHA 1efd43dView commit details -
also changed class Car's property, totalMovementDashArray, from private to public because App.js need all the properties of each Car's instances to yield Maximum number of movements. and updated README.md fisnished to make features except testing. I forgot to commit above changes just because this developing is pretty faster than I predict after sophisticately making README.md. I would change previous commits by rebase.
Configuration menu - View commit details
-
Copy full SHA for b545b90 - Browse repository at this point
Copy the full SHA b545b90View commit details
Commits on Oct 31, 2023
-
Style: added aid comment for exception on car name
noted for considering a zero-length name case.
Configuration menu - View commit details
-
Copy full SHA for ab14b25 - Browse repository at this point
Copy the full SHA ab14b25View commit details -
for considering only "," as seperator if there are other characters, they would be considered characters for car name
Configuration menu - View commit details
-
Copy full SHA for 754561c - Browse repository at this point
Copy the full SHA 754561cView commit details -
Test: input test for trial number
considered error case that the trial input value is not integer also, deleted testing valid greater than 100 for trial number because it doesn't need to split it from just testing integer also, deleted unused helper function
Configuration menu - View commit details
-
Copy full SHA for 1473fa3 - Browse repository at this point
Copy the full SHA 1473fa3View commit details -
Fix: added blank with ',' between winnders for output
if not using join function, there no blank between winners.
Configuration menu - View commit details
-
Copy full SHA for b4abba3 - Browse repository at this point
Copy the full SHA b4abba3View commit details -
Test: output test for ordinary, one winner case
for only printing one winner, which is ordinary and standard case
Configuration menu - View commit details
-
Copy full SHA for 6782261 - Browse repository at this point
Copy the full SHA 6782261View commit details -
Test: output test for ordinary, multi-winners case
for checking form connecting winners with ", "
Configuration menu - View commit details
-
Copy full SHA for f05ecd7 - Browse repository at this point
Copy the full SHA f05ecd7View commit details -
Test: output test for when trial number is 0
with 0 trial, all cars are at the same position, which means all of them are winners
Configuration menu - View commit details
-
Copy full SHA for 128840a - Browse repository at this point
Copy the full SHA 128840aView commit details -
Style: removed comments, fix test name for trial number
it doesn't need comments because of test name
Configuration menu - View commit details
-
Copy full SHA for 0d0b851 - Browse repository at this point
Copy the full SHA 0d0b851View commit details
There are no files selected for viewing