Shrink NaN to canonical form #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobh
commented
Feb 27, 2025
hypothesis-python/src/hypothesis/internal/conjecture/shrinking/common.py
Show resolved
Hide resolved
jobh
commented
Feb 27, 2025
jobh
commented
Feb 27, 2025
hypothesis-python/src/hypothesis/internal/conjecture/shrinking/common.py
Show resolved
Hide resolved
jobh
force-pushed
the
nan-shrink
branch
3 times, most recently
from
1c8bae9 to
6f2447c
Compare
tybug
reviewed
Feb 27, 2025
hypothesis-python/src/hypothesis/internal/conjecture/shrinking/floats.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4277.
The first issue (
-nan) is a one-liner, switching fromsign_aware_ltetomath.copysignto detect the sign of a choice.Second issue (
struct.unpack('d', struct.pack('Q', 0xfff8000000000001))[0]) requires distinguishing NaNs in float shrinking, so that code is reshuffled a bit to separate out the "immutable" value for the shrinker from the "hashable" value for tracking of seen values.