Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups don't always show on a Post in the Feed when most helpful #594

Open
lorenjohnson opened this issue Oct 31, 2022 · 0 comments
Open

Comments

@lorenjohnson
Copy link
Member

Currently mostly an issue on Parent Group feeds where the child groups the Post is posted to don't show-up.

Case when GroupsList SHOULD NOT be shown:

  • In a Group Stream, it is not a Public Post, and the Post is only posted to one group which is the same as the currentGroup.

Cases when GroupsList SHOULD be shown:

  1. In a Public or All Stream
  2. Is a Public Post
  3. One of the groups the posted to is not the currentGroup
  4. The Post is rendering on a Member feed and/or in a modal
  5. Maybe ALWAYS on Post Details ?

Perhaps convert current GroupsList to render/not render simply based on whether the groups prop is provided vs the the showGroups logic currently in place.

A snippet of relevant code...

  const showGroups = isModal || post?.groups.find(g => g.slug !== currentGroup?.slug)
  const groupsToShow = post.groups
  // post.isPublic && PUBLIC_GROUP
  const groups = includePublic
    ? [...providedGroups, PUBLIC_GROUP]
     : providedGroups
@lorenjohnson lorenjohnson moved this to Backlog in Hylo Dev Oct 31, 2022
@lorenjohnson lorenjohnson moved this from Backlog to In Progress in Hylo Dev Nov 1, 2022
@lorenjohnson lorenjohnson moved this from In Progress to Backlog in Hylo Dev Nov 1, 2022
@lorenjohnson lorenjohnson moved this from Backlog to Current Sprint in Hylo Dev Nov 18, 2022
@lorenjohnson lorenjohnson added this to the HyloApp 5.2.0 milestone Nov 18, 2022
@lorenjohnson lorenjohnson removed this from the HyloApp 5.1.2 milestone Dec 3, 2022
@lorenjohnson lorenjohnson moved this from Current Sprint to Backlog in Hylo Dev Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant