Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/docker: continue to deploy master images #19274

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I noticed that master images have not been updated since #18912:

$ docker run --pull=always --rm -it homebrew/brew:master brew --version
master: Pulling from homebrew/brew
Digest: sha256:3812ffd9b728ce3d96a2a362ef33bed420d1dc73c7d96c93a8f8d2d4f10e6281
Status: Image is up to date for homebrew/brew:master
Homebrew 4.4.11-6-geae8d1b
Homebrew/homebrew-core (git revision 9610909d254; last commit 2024-12-10)

That is due to images no longer being built on master pushes. This change restores the previous behaviour.

I noticed that `master` images have not been updated since #18912:

    $ docker run --pull=always --rm -it homebrew/brew:master brew --version
    master: Pulling from homebrew/brew
    Digest: sha256:3812ffd9b728ce3d96a2a362ef33bed420d1dc73c7d96c93a8f8d2d4f10e6281
    Status: Image is up to date for homebrew/brew:master
    Homebrew 4.4.11-6-geae8d1b
    Homebrew/homebrew-core (git revision 9610909; last commit 2024-12-10)

That is due to images no longer being built on `master` pushes. This
change restores the previous behaviour.
@Bo98 Bo98 added this pull request to the merge queue Feb 9, 2025
Merged via the queue into master with commit 6567eb2 Feb 9, 2025
35 checks passed
@Bo98 Bo98 deleted the docker-master-images branch February 9, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants