update-python-resources: add option to ignore errors #19252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly useful for third-party Python formulae that have a ton of resources, not all of which may adhere to homebrew/core's strict policies. See #19240 for context.
I've also added logic that ignores
--ignore-errors
onhomebrew/core
, although I personally think this new behavior is also useful for mainline formula creation.Before: error out on a single non-conforming resource, zero resource blocks added to formula, scary stacktrace (in debug mode).
After: all conforming resources added, all non-conforming resources identified in comments, error message at end,
brew
exits non-zero without scary stacktrace:-brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?