Bump rebdhuhn from 0.3.1 to 0.4.0; Make kroki-port configurable via env var; Clean Up docker image #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rebdhuhn](https://github.com/Hochfrequenz/rebdhuhn) from 0.3.1 to 0.4.0. - [Release notes](https://github.com/Hochfrequenz/rebdhuhn/releases) - [Commits](Hochfrequenz/rebdhuhn@v0.3.1...v0.4.0) --- updated-dependencies: - dependency-name: rebdhuhn dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hf-kklein
reviewed
Oct 29, 2024
hf-kklein
reviewed
Oct 29, 2024
hf-kklein
changed the title
added 3 commits
October 29, 2024 18:55
hf-kklein
reviewed
Oct 29, 2024
* remove healthcheck and networkmode host and make it more explicit which env file is getting used * make host name for kroki configurable * add config extra='ignore' * add test for base settings * remove pylint ignore command * fix path for linting * lower coverage threshold to 43 * ignore mypy, again * don't change linter setup in PR that attempts to fix docker ;) * fix type_check in unittests * add KROKI_HOST to env example * Remove docker-compose code from readme * avoid loading from .env in test case --------- Co-authored-by: konstantin <konstantin.klein@hochfrequenz.de> Co-authored-by: Konstantin <konstantin.klein+github@hochfrequenz.de>
hf-kklein
reviewed
Oct 30, 2024
| network_mode: host | ||
| ``` | ||
| 4. Login to GitHub Container Registry (GHCR); Use a [Personal Access Token](https://github.com/settings/tokens/new) (PAT) to login that has access to this repository and at least `read:packages` scope | ||
| 3. Login to GitHub Container Registry (GHCR); Use a [Personal Access Token](https://github.com/settings/tokens/new) (PAT) to login that has access to this repository and at least `read:packages` scope |
There was a problem hiding this comment.
@hf-krechan was macht man denn anstatt der der docker-compose? also konkret geht es mir ums setup hier: https://github.com/Hochfrequenz/edi_energy_mirror/blob/master/ebd-tooling/docker-compose.yaml was mache ich da stattdessen?
There was a problem hiding this comment.
den Schritt braucht man hier nicht, da wir kein Image von GH laden.
Außer du willst das docker image welches mit der Dockerfile hier im repo beschrieben wird auch in die GH Container Registry ablegen.
hf-kklein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rebdhuhn from 0.3.1 to 0.4.0.
Release notes
Sourced from rebdhuhn's releases.
Commits
8c564b7fix: make kroki client (and port) configurable (#281)1941b37chore/lint: use strict type-check in tests (#282)d681046reduce opacity of Hochfrequenz logo (#279)bb79c74fix(docs): replace single quote with backtick for code-style package … (#280)a1d2c14Bump mypy from 1.12.1 to 1.13.0 (#278)ba6ece7fix(docs): copy paste error in status badge; license is GPL, not MIT (#277)df2cb33Bump types-requests from 2.32.0.20240914 to 2.32.0.20241016 (#275)578ca6aBump networkx from 3.4.1 to 3.4.2 (#276)47db6e5Bump coverage from 7.6.3 to 7.6.4 (#274)6719ae6Bump mypy from 1.12.0 to 1.12.1 (#273)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)