Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't ignore untyped calls in mypy #63

Merged
merged 1 commit into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ max-line-length = 120
truethy-bool = true

[tool.mypy]
disable_error_code = ["no-untyped-def", "no-untyped-call"]
disable_error_code = []

[build-system]
requires = ["hatchling>=1.8.0", "hatch-vcs", "hatch-fancy-pypi-readme"]
Expand Down
2 changes: 1 addition & 1 deletion src/ebd_toolchain/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def _dump_json(json_path: Path, ebd_table: EbdTable) -> None:
help="Choose which file you'd like to create",
)
# pylint:disable=too-many-locals, too-many-branches, too-many-statements,
def main(input_path: Path, output_path: Path, export_types: list[Literal["puml", "dot", "json", "svg"]]):
def main(input_path: Path, output_path: Path, export_types: list[Literal["puml", "dot", "json", "svg"]]) -> None:
"""
A program to get a machine-readable version of the AHBs docx files published by edi@energy.
"""
Expand Down
2 changes: 1 addition & 1 deletion src/ebd_toolchain/mymodule.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class MyClass: # pylint: disable=too-few-public-methods
This is a docstring for the class.
"""

def __init__(self):
def __init__(self) -> None:
"""
Initialize for the sake of initializing
"""
Expand Down
2 changes: 1 addition & 1 deletion unittests/test_myclass.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ class TestMyClass:
A class with pytest unit tests.
"""

def test_something(self):
def test_something(self) -> None:
my_class = MyClass()
assert my_class.do_something() == "abc"