refactor: simplify main #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
reviewed
Jan 27, 2025
Comment on lines
-166
to
-192
| if "json" in export_types: | ||
| json_path = output_path / Path(f"{ebd_key}.json") | ||
| _dump_json(json_path, ebd_meta_data) | ||
| click.secho(f"💾 Successfully exported '{ebd_key}.json' to {json_path.absolute()}") | ||
| try: | ||
| ebd_graph = convert_empty_table_to_graph(ebd_meta_data) | ||
| except ( | ||
| EbdCrossReferenceNotSupportedError, | ||
| EndeInWrongColumnError, | ||
| OutcomeCodeAmbiguousError, | ||
| ) as known_issue: | ||
| handle_known_error(known_issue, ebd_key) | ||
| continue | ||
| except Exception as unknown_error: # pylint:disable=broad-except | ||
| click.secho(f"Error while graphing {ebd_key}: {str(unknown_error)}; Skip!", fg="red") | ||
| continue | ||
| try: | ||
| if "dot" in export_types: | ||
| dot_path = output_path / Path(f"{ebd_key}.dot") | ||
| _dump_dot(dot_path, ebd_graph) | ||
| click.secho(f"💾 Successfully exported '{ebd_key}.dot' to {dot_path.absolute()}") | ||
| if "svg" in export_types: | ||
| svg_path = output_path / Path(f"{ebd_key}.svg") | ||
| _dump_svg(svg_path, ebd_graph, kroki_client) | ||
| click.secho(f"💾 Successfully exported '{ebd_key}.svg' to {svg_path.absolute()}") | ||
| except (PathsNotGreaterThanOneError, KrokiDotBadRequestError) as known_issue: | ||
| handle_known_error(known_issue, ebd_key) |
There was a problem hiding this comment.
gehen uns hier nicht features verloren?
also das schreiben der dot und svg und json dateien und so?
There was a problem hiding this comment.
Sollte eigentlich nicht, weil im R_EBD_huhn die convert_empty_table_to_graph(ebd_meta_data) Funktion auch in der convert_table_to_graph Funktion aufgerufen wird. Ich musste gerade für den puml Zweig noch etwas anpassen. Da sind leere EBD Tabellen noch nicht unterstützt.
There was a problem hiding this comment.
folgender vorschlag:
- wir mergen den rebdhuhn PR und bumpen hier (auf main und in diesem branach) die version von rebdhuhn, entweder manuell oder indem man https://github.com/Hochfrequenz/ebd_toolchain/network/updates aufruft und den dependabot manuell triggert
- dann bauen wir ein pre-release der toolchain auf diesem simplify_main feature branch
- dann bumpen wir die version der toolchain im mirror: https://github.com/Hochfrequenz/edi_energy_mirror/blob/46ca47810e4eb6f7d0fa0d7868acddb0d80294af/ebd-tooling/docker-compose.yaml#L7 (gerne direkt aufm master-branch) auf die pre-release version und schauen ob es klappt
wenn es klappt, dann bin ich überzeugt :)
There was a problem hiding this comment.
Ich bin selber gespannt 🙈
hf-kklein
approved these changes
Jan 28, 2025
OLILHR
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.