Add Favicon #22
Merged
Add Favicon #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyBom
reviewed
May 20, 2024
| <link rel="icon" href="/assets/favicon/hf_logo.svg" type="image/svg+xml"> | ||
| <link rel="apple-touch-icon" href="/assets/favicon/apple-touch-icon.png"><!-- 180×180 --> | ||
| <link rel="manifest" href="/assets/favicon/manifest.webmanifest"> | ||
| <nav class="mx-auto flex max-w-7xl items-center justify-between p-6 lg:px-8" aria-label="Global"> |
There was a problem hiding this comment.
header != head
Please use the index.html file. This component renders a header element in the html body.
There was a problem hiding this comment.
moved in 566d0ad
There was a problem hiding this comment.
you copied it to the index.html, but forgot to remove it here
There was a problem hiding this comment.
I removed it, but I got some issues with git.
But now it should be gone ^^
TommyBom
requested changes
May 20, 2024
TommyBom
requested changes
May 20, 2024
TommyBom
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just followed this blog entry: https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs
Not totally sure if this is the "angular" way ^^
Fixes #20