Fix file-open-save-new-core to make it fully-functional

HiromuHota · Feb 6, 2020 · d90d0eb · d90d0eb
1 parent e17afe0
commit d90d0eb
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 3 deletions.
diff --git a/integration/src/test/java/org/pentaho/di/ui/spoon/WebSpoonTest.java b/integration/src/test/java/org/pentaho/di/ui/spoon/WebSpoonTest.java
@@ -142,6 +142,16 @@ public void testOpenSaveMenus() {
     assertFalse( isMenuItemDisabled( "//div[text() = 'Save as (VFS)...']" ) );
   }
 
+  @Test
+  public void testOpenSaveNewDialog() {
+    clickElement( "//div[text() = 'File']" );
+    assertFalse( isMenuItemDisabled( "//div[text() = 'Open URL...']" ) );
+    clickElement( "//div[text() = 'Open URL...']" ); // Open the new dialog
+    driver.switchTo().frame( driver.findElement( By.xpath(".//iframe[starts-with(@src, '/spoon/osgi/@pentaho/di-plugin-file-open-save-new@9.0.0.0-423/index.html')]") ) );
+    wait.until( ExpectedConditions.presenceOfElementLocated( By.xpath( "//div[contains(text(),'Local')]" ) ) );
+    assertEquals( 1, driver.findElements( By.xpath( "//div[contains(text(),'Local')]" ) ).size() );
+  }
+
   @Test
   public void testDatabaseConnectionDialog() throws Exception {
     // Create a new transformation

diff --git a/...new/core/src/main/java/org/pentaho/di/plugins/fileopensave/dialog/FileOpenSaveDialog.java b/...new/core/src/main/java/org/pentaho/di/plugins/fileopensave/dialog/FileOpenSaveDialog.java
@@ -154,19 +154,25 @@ public void open( FileDialogOperation fileDialogOperation ) {
 
     new BrowserFunction( browser, "close" ) {
       @Override public Object function( Object[] arguments ) {
+        Runnable execute = () -> {
         closeBrowser( browser );
+        };
+        display.asyncExec( execute );
         return true;
       }
     };
 
     new BrowserFunction( browser, "select" ) {
       @Override public Object function( Object[] arguments ) {
+        Runnable execute = () -> {
         try {
           setProperties( arguments );
           closeBrowser( browser );
         } catch ( Exception e ) {
           log.logError( "Error in processing select() from file-open-save app: ", e );
         }
+        };
+        display.asyncExec( execute );
         return true;
       }
     };

diff --git a/plugins/file-open-save-new/core/src/main/javascript/app/services/data.service.js b/plugins/file-open-save-new/core/src/main/javascript/app/services/data.service.js
@@ -79,7 +79,7 @@ define(
 
           var options = {
             method: method,
-            url: _cacheBust(url),
+            url: CONTEXT_PATH + _cacheBust(url),
             headers: {
               Accept: "application/json"
             },
@@ -335,7 +335,7 @@ define(
         function _wrapHttp(method, url, data, timeout) {
           var options = {
             method: method,
-            url: _cacheBust(url),
+            url: CONTEXT_PATH + _cacheBust(url),
             headers: {
               Accept: "application/json"
             },
@@ -360,6 +360,8 @@ define(
           } else {
             url += "?v=" + value;
           }
+          var cid = getConnectionId();
+          url += "&cid=" + cid;
           return url;
         }
       }

diff --git a/plugins/file-open-save-new/core/src/main/javascript/app/services/helper.service.js b/plugins/file-open-save-new/core/src/main/javascript/app/services/helper.service.js
@@ -109,7 +109,7 @@ define(
         function _wrapHttp(method, url, data) {
           var options = {
             method: method,
-            url: _cacheBust(url),
+            url: CONTEXT_PATH + _cacheBust(url),
             headers: {
               Accept: "application/json"
             }
@@ -133,6 +133,8 @@ define(
           } else {
             url += "?v=" + value;
           }
+          var cid = getConnectionId();
+          url += "&cid=" + cid;
           return url;
         }
       }

diff --git a/plugins/file-open-save-new/core/src/main/resources-filtered/OSGI-INF/blueprint/blueprint.xml b/plugins/file-open-save-new/core/src/main/resources-filtered/OSGI-INF/blueprint/blueprint.xml
@@ -47,6 +47,7 @@
       <bean class="org.pentaho.di.plugins.fileopensave.endpoints.JsonProvider">
         <argument ref="providerService" />
       </bean>
+      <bean class="org.pentaho.di.ui.repo.endpoints.WebSpoonFilter"/>
     </jaxrs:providers>
 
   </jaxrs:server>