Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HiPACE_CCACHE Option #1065

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 1, 2024

Cleaner way to disable CCache in package managers.

See ECP-WarpX/WarpX#4637

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Cleaner way to disable CCache in package managers.
@ax3l ax3l added the build CMake, compilation, etc. label Feb 1, 2024
Copy link
Member

@AlexanderSinn AlexanderSinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@AlexanderSinn AlexanderSinn merged commit a94f580 into Hi-PACE:development Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CMake, compilation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants