Обновил логику добавления в контекст последних 10 пулл реквестов и проблем на главной странице #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he context on the main page home.py , added a new template to compontents/latest_issues_and_pr.html , changed the code in the JS script.
|
@thiSSSnake задеплойте, пожалуйста, демку. |
fey
reviewed
Jun 5, 2024
| @@ -35,7 +35,7 @@ function time_note(data_type) { | |||
|
|
|||
|
|
|||
| document.addEventListener('DOMContentLoaded', start('top-week')); | |||
| document.addEventListener('DOMContentLoaded', start('latest-for-week')); | |||
| document.addEventListener('DOMContentLoaded', start('latest-in-recent-times')); | |||
There was a problem hiding this comment.
а нам это действительно нужно? По идее в бутстрапе табы работают из корробки. И по идее должен по дефолту просто открываться один там.
Жду демку, посмотрю, что внутри.
There was a problem hiding this comment.
@fey При деплое столкнулся с проблемой, сервер отдает 500 ошибку, хотя деплой успешно прошел да и локально сервер работает, allowed_hosts в конфиге не трогал, деплоил по инстуркции в репозитории...буду смотреть сегодня в чем дело :/
There was a problem hiding this comment.
@fey проблема была в том что я новый шаблон в коммит не добавил -__-. Ссылка на демо -- https://hexlet-friends-w4ta.onrender.com
|
посмотрел. ну навертели тут всякого конечно когда-то)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Обновил логику добавления в контекст последних 10 пулл реквестов и проблем на главной странице в home.py, добавил новый шаблон в compontents/latest_issues_and_pr.html, изменил код в JS скрипте.