Datepicker for advanced movie options blocks out dates that it shouldn't #498
Labels
Comments
|
Hey, l will like to be assigned on this issue |
|
@aayushtmG all yours. |
|
@aayushtmG Try following the instructions in the readme here for running hv locally for testing. |
|
Is this resolved? can I PR? |
|
Not resolved yet, you can PR |
|
Not able to reproduce this! EDIT:
Reproduced it! |
raptor-07
added a commit
to raptor-07/helioviewer.org
that referenced
this issue
Dec 6, 2023
Datepicker for advanced movie options blocks out dates that it shouldn't. 'maxDate' option defaults to null. reference: https://flatpickr.js.org/options/ The option has been removed from flatpickr instance. This allows user to select future dates.
|
Review PR please! |
raptor-07
added a commit
to raptor-07/helioviewer.org
that referenced
this issue
Dec 6, 2023
Helioviewer-Project#512 PR review suggested further changes. doOpen handler is entirely removed
dgarciabriseno
pushed a commit
that referenced
this issue
Dec 14, 2023
* Issue #498 - Update MovieManagerUI.js Datepicker for advanced movie options blocks out dates that it shouldn't. 'maxDate' option defaults to null. reference: https://flatpickr.js.org/options/ The option has been removed from flatpickr instance. This allows user to select future dates. * #498 - Update MovieManagerUI.js #512 PR review suggested further changes. doOpen handler is entirely removed
|
This was completed with PR #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is using flatpickr, I think it's set to black out dates beyond the end date, but that makes it feel clunky.
Just need to remove the
maxDateoption on the flatpickr instance on#movie-start-dateinMovieManagerUI.js.The text was updated successfully, but these errors were encountered: