[Notepad++ Plugin] Validation fails with XML comments

[TheYorkshireDev]

I have been using the excellent Notepad++ FHIR plugin you provide which includes validation of FHIR messages. I have noticed though that validation fails when you have a comment in an XML message.

I am aware that the JSON spec does not allow comments, but XML does allow for comments and since the FHIR can be written in XML I believe that the validation from the plugin should ignore XML comments.

---

Below is a a couple of messages to demonstrate the issue above.

XML FHIR message WITHOUT a comment that PASSES validation:

<?xml version="1.0" encoding="UTF-8"?>
<Bundle xmlns="http://hl7.org/fhir">
  <id value="urn:uuid:77831928-2a35-4c08-9496-8232323bf48c"/>
  <type value="message"/>
  <entry>
    <fullUrl value="urn:uuid:6080d4a7-5e05-45dc-96d5-f75329564d1f"/>
    <resource>
      <MessageHeader>
        <id value="644e1dd7-2a7f-18fb-b8ed-ed78c3f92c2b"/>
        <event>
          <system value="http://hl7.org/fhir/message-events"/> 
          <code value="admin-notify"/>
        </event>
        <receiver>
          <reference value="Organization/2"/>
        </receiver>
        <sender> 
          <reference value="Organization/1"/> 
        </sender>
        <timestamp value="2012-01-04T09:10:14Z"/>
        <source>
          <endpoint value="llp:10.11.12.13:5432"/>
        </source>
      </MessageHeader>
    </resource>
  </entry>
</Bundle>

XML FHIR message WITH a comment that FAILS validation:

<?xml version="1.0" encoding="UTF-8"?>
<Bundle xmlns="http://hl7.org/fhir">
  <id value="urn:uuid:77831928-2a35-4c08-9496-8232323bf48c"/>
  <type value="message"/>
  <entry>
    <fullUrl value="urn:uuid:6080d4a7-5e05-45dc-96d5-f75329564d1f"/>
    <resource>
      <MessageHeader>
        <id value="644e1dd7-2a7f-18fb-b8ed-ed78c3f92c2b"/>
        <!-- A small comment that fails validation -->
        <event>
          <system value="http://hl7.org/fhir/message-events"/> 
          <code value="admin-notify"/>
        </event>
        <receiver>
          <reference value="Organization/2"/>
        </receiver>
        <sender> 
          <reference value="Organization/1"/> 
        </sender>
        <timestamp value="2012-01-04T09:10:14Z"/>
        <source>
          <endpoint value="llp:10.11.12.13:5432"/>
        </source>
      </MessageHeader>
    </resource>
  </entry>
</Bundle>

Validation Output:

Severity	Location	Details	Diagnostics	Type
error	MessageHeader	Text should not be present at line 8 col 7		structure

[grahamegrieve]

This works ok for me - what version are you using?

[TheYorkshireDev]

@grahamegrieve I am running the following version

Plugin Version: 1.0.28
FHIR Version: 3.0.1

[grahamegrieve]

well, that's not it. a screen shot?

[TheYorkshireDev]

@grahamegrieve Attached is a screenshot of the fhir message and the output of validation.

If it is any use I am running Windows 10 Pro x64, and my Notepad++ version is v7.5.6 (32-bit)

[grahamegrieve]

how did you invoke the validation? this looks like an error from a server, not the built in validator Grahame

…

On Wed, Apr 18, 2018 at 6:02 PM, Steven Cooney ***@***.***> wrote: @grahamegrieve <https://github.com/grahamegrieve> Attached is a screenshot of the fhir message and the output of validation. [image: image] <https://user-images.githubusercontent.com/30004860/38918897-ef813fe6-42e6-11e8-80cb-1d468f173029.png> If it is any use I am running *Windows 10 Pro x64*, and my Notepad++ version is *v7.5.6 (32-bit)* — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#89 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFllFVdqLqJXofbADqlPVS979Cgm9eRrks5tpvMjgaJpZM4TWHgZ> .

-- ----- http://www.healthintersections.com.au / grahame@healthintersections.com.au / +61 411 867 065

[TheYorkshireDev]

@grahamegrieve I have been validating the message using the Validation Resource button on the FHIR toolbox (4th button in).

Is there another way or a way which only validates locally?

[grahamegrieve]

no. that way. It's just that the error message is wrong and impossible. I'll.... do something....

…

On Fri, Apr 20, 2018 at 6:30 PM, Steven Cooney ***@***.***> wrote: @grahamegrieve <https://github.com/grahamegrieve> I have been validating the message using the Validation Resource button on the FHIR toolbox (4th button in). [image: image] <https://user-images.githubusercontent.com/30004860/39039337-3d5bb272-447d-11e8-8b64-328268d53515.png> Is there another way or a way which only validates locally? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#89 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFllFbx8X1v3W4qD-X_DuOFfmkHpj26wks5tqZyIgaJpZM4TWHgZ> .

-- ----- http://www.healthintersections.com.au / grahame@healthintersections.com.au / +61 411 867 065

[TheYorkshireDev]

@grahamegrieve did you ever make any further progress on this?

[grahamegrieve]

I started to rewrite the validation thing and part of it was to look at this, but it turned into a nightmare monster that still isn’t complete. I’ll let you know when I have the new version Grahame

…

On 10 May 2018, at 5:22 pm, Steven Cooney ***@***.***> wrote: @grahamegrieve did you ever make any further progress on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.