Peer Review - Frontend data & Functional Patterns

[veerleprins]

Scan someone else's repository

• Repo is correctly named (frontend data) ✅
• There is a .gitignore with the right names in it. ✅
• There is a link to github pages, but nothing of a static / interactive graph can be seen here.
• There is a description, just not yet exactly what you do specifically in this repo. (by this I mean: an interactive visualization with the library D3 in javascript to set the park and rides against the years, for example)
• It is clear what your concept is! Perhaps you can add images to your wiki to be able to see what you are doing in 1 view (without having to read the entire text), this helps the reader. ✅
• No image of the visualization has yet been displayed in the readme.
• No example has yet been named in the readme from which you got your code.
• You do have your main question, which data you want to use and a sketch in your wiki to which you link from your ReadMe. ✅
• You have not yet described how you use your data from the RDW (neither in the wiki nor in your readme). The wiki only contains information about the survey data!
• You also haven't really described where you got your code from (from curran, among others, I assume) and almost no source reference. 😔

Wiki

• I can follow the data cleaning and transformation process, but you have nothing based on your RDW data (only on your survey data). Not that that's bad for functional programming, but as a reader I now have no idea how or whether you cleaned up your RDW data.
• The update pattern has not yet been documented.
• You could therefore still describe in your wiki what you have done with your RDW data and what you have learned from it, this is now unknown to me!

Live demo

• There is no live demo available yet. 😔
• I can see your graph in the vizhub, that looks good 👍

Note:

Nice that you made a pie chart!
Try to go through every point of the rebric today and see: do I have everything?
But that will be fine, good luck 💪