Return numpy dtype from eiger-stream-v1 #768
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the other imageseries adapters return a numpy dtype. Here, we were just returning a string representing a dtype. However, we should return a numpy dtype to be consistent with all of the other imageseries adapters as well. This also fixes issues in other places in the code where it is assumed that a numpy dtype is returned from the imageseries. Fixes: hexrd/hexrdgui##1780 Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
=======================================
Coverage 46.12% 46.12%
=======================================
Files 142 142
Lines 22822 22822
=======================================
Hits 10526 10526
Misses 12296 12296 ☔ View full report in Codecov by Sentry. |
bnmajor
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the other imageseries adapters return a numpy dtype. Here, we were just returning a string representing a dtype. However, we should return a numpy dtype to be consistent with all of the other imageseries adapters as well.
This also fixes issues in other places in the code where it is assumed that a numpy dtype is returned from the imageseries.
Fixes: HEXRD/hexrdgui#1780