Move filtering code into hera_filters. #144
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move filtering code out of
uvtools
into thehera_filters
repository.hera_filters
is at https://github.com/HERA-Team/hera_filters . The reason for this change is that foreground filtering is widely applicable beyond HERA and it makes sense to decouple it from the visualization functionality inuvtools
and the associated dependancies. We may want to change the name ofuvtools
tohera_visualization
if we decide to add substantially more plotting functionality in the future.For now, I've preserved
uvtools.dspec
and just importhera_filters
methods. In a future PR (after people have had time to migrate downstream code) we should probably completely eliminateuvtools.dspec
.