Temporary fix for future array shape #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyuvdata switched to using `future_array_shapes` by default from `pyuvdata>=2.7.0`. Many functionality of `hera_sim=2.x.x` relies on the `current_array_shapes`. The full fixes are planned for `hera_sim=3.0.0`.
steven-murray
approved these changes
Feb 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 96.56% 96.54% -0.03%
==========================================
Files 24 24
Lines 2798 2804 +6
==========================================
+ Hits 2702 2707 +5
- Misses 96 97 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyuvdata switched to using
future_array_shapesby default frompyuvdata>=2.7.0. Many functionalities ofhera_sim=2.x.xrelies on thecurrent_array_shapes(see, e.g., #211). This PR provides a temporary fix to this issue The full fix is planned forhera_sim=3.x.x.