add cleanParams

src/__tests__/book-repository.test.ts

@@ -1,7 +1,7 @@
 import dayjs from "dayjs";
 import { PlainObject } from "../index";
 import { BookModel } from "./helper/book-model";
-import { USE_API } from "./helper/helper";
+import { USE_API, mock } from "./helper/helper";
 import { Book } from "./helper/book-repository";
 import { setupGithubMock } from "./mock/mock-github-api";
 
@@ -65,7 +65,7 @@ describe('Test Book Storage', () => {
         if (USE_API) {
             await Book.deleteAll();
         } else {
-            await setupGithubMock();
+            setupGithubMock();
         }
     });
 
@@ -149,7 +149,7 @@ describe('Test Book Storage', () => {
         }
     });
 
-    (USE_API ? test: test.skip)('Test createAll Book', async () => {
+    (USE_API ? test : test.skip)('Test createAll Book', async () => {
         await Book.deleteAll();
         const result = await Book.createAll(bookList);
         expect(result.length).toEqual(10);
@@ -176,6 +176,11 @@ describe('Test Book Storage', () => {
         });
     });
 
+    test('Test find Book with params since undefined', async () => {
+        const result = await Book.find({ since: undefined });
+        expect(result.length).toBeGreaterThan(0);
+    });
+
     test('Test find Book with params page & per_page', async () => {
         const firstPage = await Book.find({ page: 1, per_page: 3 });
         expect(firstPage.length).toEqual(3);
@@ -184,9 +189,9 @@ describe('Test Book Storage', () => {
         expect(lastPage.length).toEqual(1);
     });
 
-    test('Test get Book Detail', async()=>{
+    test('Test get Book Detail', async () => {
         const result = await Book.detail();
-        const {id, issue_number, comments, created_at, updated_at} = result;
+        const { id, issue_number, comments, created_at, updated_at } = result;
         expect(id).not.toBeNull();
         expect(issue_number).not.toBeNull();
         expect(comments).not.toBeNull();

src/__tests__/chat-repository.test.ts

@@ -235,6 +235,11 @@ describe('Use Gitlab Test Chat Storage', () => {
         expect(findAsc.map(item => item.id)).toEqual(findDesc.map(item => item.id).reverse());
     });
 
+    test('Test find Chat with params sort & order_by undefined', async () => {
+        const result = await Chat.find({ sort: undefined, order_by: undefined });
+        expect(result.length).toBeGreaterThan(0);
+    });
+
     test('Test get Chat Detail', async()=>{
         const result = await Chat.detail();
         const {id, issue_number, comments, created_at, updated_at} = result;

src/__tests__/helper/helper.ts

@@ -8,8 +8,6 @@ import timezone from 'dayjs/plugin/timezone';
 import MockAdapter from 'axios-mock-adapter';
 import jsonfile from 'jsonfile';
 
-// export const mock = new MockAdapter(axios);
-
 dayjs.extend(utc);
 dayjs.extend(timezone);
 dayjs.tz.setDefault('Asia/Shanghai');

src/__tests__/mock/mock-gitee-api.ts

@@ -16,6 +16,11 @@ export function setupGiteeMock() {
 function mockGiteeFind() {
     mock?.onGet(`https://gitee.com/api/v5/repos/${GITEE_OWNER}/${GITEE_REPO}/issues/${GITEE_NUMBER}/comments`).reply(async (config) => {
         const result = readJSONSync(filename);
+        if (config.params) {
+            Object.values(config.params).forEach((item)=>{
+                expect(item).not.toBeNull();
+            });
+        }
         if (config.params?.since) {
             return [200, result.filter((item: any) => dayjs(item.created_at).isAfter(dayjs(config.params.since)))];
         }

src/__tests__/mock/mock-github-api.ts

@@ -16,6 +16,11 @@ export function setupGithubMock() {
 function mockGithubFind() {
     mock?.onGet(`https://api.github.com/repos/${GITHUB_OWNER}/${GITHUB_REPO}/issues/${GITHUB_NUMBER}/comments`).reply(async (config) => {
         const result = readJSONSync(filename);
+        if (config.params) {
+            Object.values(config.params).forEach((item)=>{
+                expect(item).not.toBeNull();
+            })
+        }
         if (config.params?.since) {
             return [200, result.filter((item: any) => dayjs(item.created_at).isAfter(dayjs(config.params.since)))];
         }

src/__tests__/mock/mock-gitlab-api.ts

@@ -16,6 +16,11 @@ export function setupGitlabMock() {
 function mockGitlabFind() {
     mock?.onGet(`https://gitlab.com/api/v4/projects/${GITLAB_PROJECT_ID}/issues/${GITLAB_NUMBER}/notes`).reply(async (config) => {
         const result = readJSONSync(filename);
+        if (config.params) {
+            Object.values(config.params).forEach((item)=>{
+                expect(item).not.toBeNull();
+            });
+        }
         if (config.params?.sort) {
             const sort = config.params?.sort;
             result.sort((a: any, b: any) => {

src/__tests__/user-repository.test.ts

@@ -163,6 +163,11 @@ describe('Test User Repository', () => {
         expect(lastPage.length).toEqual(1);
     });
 
+    test('Test find user with params page & per_page undefined', async () => {
+        const result = await User.find({ page: undefined, per_page: undefined });
+        expect(result.length).toBeGreaterThan(0);
+    });
+
     test('Test get User Detail', async()=>{
         const result = await User.detail();
         const {id, issue_number, comments, created_at, updated_at} = result;

src/repository-lib/base/base-repository.ts

@@ -48,6 +48,22 @@ export abstract class BaseRepository<T extends BaseModel> {
         }
     }
 
+    /**
+     * Cleans the provided parameters by removing any properties with null or undefined values.
+     * @param params - The parameters to be cleaned.
+     * @returns The cleaned parameters or undefined if all properties are null or undefined.
+     */
+    protected cleanParams(params?: BaseParams): BaseParams | undefined {
+        if (params == null) return;
+        const copyParams = JSON.parse(JSON.stringify(params));
+        for (const key in copyParams) {
+            if (copyParams[key] == null) {
+                delete copyParams[key];
+            }
+        }
+        return Object.keys(copyParams).length > 0 ? copyParams : undefined;
+    }
+
     /**
      * Finds items in the storage based on the provided parameters.
      * @param params - The parameters used for filtering the items.

src/repository-lib/gitee/gitee-repository.ts

@@ -25,7 +25,7 @@ export class GiteeRepository<T extends BaseModel> extends BaseRepository<T> {
      * @returns A promise that resolves to an array of items.
      */
     async find(params?: GiteeParams): Promise<T[]> {
-        return super.find(params);
+        return super.find(this.cleanParams(params));
     }
 
     /**

src/repository-lib/github/github-repository.ts

@@ -24,7 +24,7 @@ export class GithubRepository<T extends BaseModel> extends BaseRepository<T> {
      * @returns A promise that resolves to an array of items.
      */
     async find(params?: GithubParams): Promise<T[]> {
-        return super.find(params);
+        return super.find(this.cleanParams(params));
     }
 
     /**

src/repository-lib/gitlab/gitlab-repository.ts

@@ -41,7 +41,7 @@ export class GitlabRepository<T extends BaseModel> extends BaseRepository<T> {
      */
     async find(params?: GitlabParams): Promise<T[]> {
         const url = this.getRoute(RouteType.find);
-        const response = await this.request.get<BaseComment[]>(url, params);
+        const response = await this.request.get<BaseComment[]>(url, this.cleanParams(params));
         return response.filter(item => item['system'] === false).map((item) => this.deserialize<T>(item));
     }