Fixed memory leaks I think

Griezn · Nov 17, 2024 · 45e8289 · 45e8289
1 parent aca79ab
commit 45e8289
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/generator.c b/src/generator.c
@@ -64,7 +64,10 @@ data_t* get_next_generator(const source_t *source) {
     }
     generator->has_next = false;
 
-    return &generator->source.buffer;
+    data_t *data = malloc(sizeof(data_t));
+    *data = generator->source.buffer;;
+
+    return data;
 }
 
 

diff --git a/src/query.c b/src/query.c
@@ -153,10 +153,12 @@ void execute_operator(const operator_t *operator_, const data_t *in, data_t *out
 void execute_query(const query_t *query, const source_t *source, sink_t *sink)
 {
     data_t data = {NULL, 0, 1};
-    data_t* next_data;
+    data_t* next_data = NULL;
 
     while ((next_data = source->get_next(source)) != NULL) {
         execute_operator(query->root, next_data, &data);
         sink->push_next(sink, &data);
+        free(next_data);
+        next_data = NULL;
     }
 }
diff --git a/tests/queryTests.cpp b/tests/queryTests.cpp
@@ -28,8 +28,12 @@ class QueryTestFixture : public ::testing::Test {
 
     void TearDown() override
     {
-        if (skip_teardown)
+        if (skip_teardown) {
+            free(gsource);
+            free(gsink);
             return;
+        }
+
         free_generator_source(gsource);
         free_generator_sink(gsink);
     }