Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable gzip for prometheus query handlers and ignore NaN values in prometheus response #5576

Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat: enable gzip for prometheus query handlers and ignore NaN values in prometheus response #5576

merged 2 commits into from
Feb 20, 2025

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Feb 20, 2025 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#5525

What's changed and what's your intention?

By default, Grafana executes multiple PromQL queries within a request sequentially. However, the VictoriaMetrics datasource plugin executes them in parallel. When Grafana and the datasource are deployed in different data centers, parallel execution can significantly reduce network latency and improve query efficiency.

This PR aims to minimize retrieval overhead as much as possible.

  1. Enable Gzip Compression for Prometheus Query Handlers
  • Enables Gzip compression to reduce response payload size, thereby lowering retrieval overhead.
  1. Ignore NaN values in Prometheus Responses
  • Aligns behavior with VictoriaMetrics and also helps reduce retrieval overhead.

Disable gzip, with NaN values
Screenshot 2025-02-20 at 14 22 00
Response size: 186 KiB, with an 800ms gap between the first request's response and the second request.

Enable gzip, with NaN values
Screenshot 2025-02-20 at 14 26 51
Response size: 24 KiB (original 186KiB), with an 440ms gap between the first request's response and the second request.

Enable gzip, without NaN values
Screenshot 2025-02-20 at 14 25 24
Response size: 7 KiB (original 56KiB), with an 200ms gap between the first request's response and the second request.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@WenyXu WenyXu requested a review from a team as a code owner February 20, 2025 06:27
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 20, 2025
fengjiachun
fengjiachun approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuiyisong
shuiyisong approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@WenyXu @shuiyisong
Apply suggestions from code review
2a02e94 
Co-authored-by: shuiyisong <113876041+shuiyisong@users.noreply.github.com>
@fengjiachun fengjiachun added this pull request to the merge queue Feb 20, 2025
Merged via the queue into GreptimeTeam:main with commit 1d8c9c1 Feb 20, 2025
37 checks passed
killme2008
killme2008 reviewed Feb 20, 2025
View reviewed changes
src/servers/src/http/result/prometheus_resp.rs
let timestamp_millis: i64 = timestamp_column.get_data(row_index).unwrap().into();
let timestamp = timestamp_millis as f64 / 1000.0;
// retrieve tags
// TODO(ruihang): push table name `__metric__`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: these two TODOs must be fixed. cc @WenyXu @waynexia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

@shuiyisong shuiyisong shuiyisong approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WenyXu @killme2008 @fengjiachun @shuiyisong