Add method to check if bus is dominant #51
+27
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epontan
force-pushed
the
bus-is-dominant
branch
from
b781a1b to
6607507
Compare
* Elide lifetimes as suggested by `clippy::needless_lifetimes`[1] * Fix doc list indentation warnings, `clippy::doc_lazy_continuation`[2], as appropriate * Add `Default` implementation for `SharedMemory` as suggested by `clippy::new_without_default`[3] [1]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [2]: https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [3]: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
Checking if the bus is dominant (i.e., the RX pin value is low) can be particularly useful in scenarios where the transceiver is put into sleep mode. Some transceivers (such as TCAN1043-Q1[1]) signals wake-up by setting the RX pin (and nFAULT) to low while being in sleep mode. To accurately tell if the transceiver requests a wake-up, the RX pin state needs to be accessible from the application. Fortunately MCAN exposes a way to read the state of the RX pin through its `TEST` register. Extend the `DynAux` trait with an additional method that reads the `RX` bit from that register. [1]: https://www.ti.com/product/TCAN1043-Q1
epontan
force-pushed
the
bus-is-dominant
branch
from
6607507 to
76f4aa2
Compare
Ironedde
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if the bus is dominant (i.e., the RX pin value is low) can be particularly useful in scenarios where the transceiver is put into sleep mode. Some transceivers (such as TCAN1043-Q11) signals wake-up by setting the RX pin (and nFAULT) to low while being in sleep mode. To accurately tell if the transceiver requests a wake-up, the RX pin state needs to be accessible from the application.
Fortunately MCAN exposes a way to read the state of the RX pin through its
TESTregister. Extend theDynAuxtrait with an additional method that reads theRXbit from that register.Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo +stable fmtwas run.cargo +stable clippyyields nowarnings.CHANGELOG.mdin the proper section.newly added features and code.