Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added network Awareness tab and features #11

Open
wants to merge 1 commit into
base: Main
Choose a base branch
from

Conversation

JoshuaMedvinskyEthlas
Copy link

Pull Request: NetworkAwareness Tab and Features

Date: August 24, 2023

Description:
This pull request adds the NetworkAwareness tab and associated features to the Sparkplate.Vue Electron project. The NetworkAwareness tab is designed to display system information and enable vCard file imports. The implementation adheres to the guidelines provided in the Greenfire Sparkplate.Vue Electron Engineer Assessment.

Changes Made:

  1. Added a new tab named "NetworkAwareness" to the SideNav with a custom SVG logo.
  2. Implemented the display of system information on the NetworkAwareness tab, including the hostname of the machine, the current username, and the local IP address for Linux, Windows, and macOS operating systems.
  3. Created a modal for importing vCard files (vcards) and displaying a QR code with the same information.

Additional Details:

  • All files, folders, variables, and functions have been named and spelled properly according to the provided guidelines.
  • Each function has been modularized and placed in separate files within the "src/" directory.
  • Comments have been added throughout the code to explain the purpose of each file and function.
  • The changes have been made on a new branch named "JMGreenfire.Sparkplate.NetworkInfoImport" as per the specified naming convention.

Testing:
I have tested the changes by running "npm run build," which successfully created packages for different operating systems and ensured that the application runs as expected.

*Node Version: v16.15.0
*Operating System: Linux

Please review the changes and let me know if any further adjustments are needed. Thank you for the opportunity to contribute to the Sparkplate.Vue project.

Best regards,
Joshua Medvinsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant