Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for an Aggregated monitoring dashboard in sharded migration #686

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

asthamohta
Copy link
Collaborator

  1. Add support for an Aggregated monitoring dashboard in sharded migration
  2. Store GCS Buckets associated with a stream
  3. Revise certain queries for sharded and unsharded migration based on discussions

Testing

  1. Sharded migration dashboard creation success
  2. Non sharded migration dashboard creation success
  3. Dashboard creation when fetching gcs bucket fails
  4. Testing dashboard creation failure

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #686 (2e48906) into master (049f8ea) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   54.27%   54.25%   -0.02%     
==========================================
  Files          65       65              
  Lines       12351    12355       +4     
==========================================
  Hits         6703     6703              
- Misses       5181     5185       +4     
  Partials      467      467              
Components Coverage Δ
backend-apis 43.54% <0.00%> (-0.05%) ⬇️
backend-library 60.21% <ø> (ø)
cli 0.00% <ø> (ø)
frontend ∅ <ø> (∅)
Files Coverage Δ
internal/convert.go 65.35% <ø> (ø)
webv2/web.go 35.50% <0.00%> (-0.06%) ⬇️

common/metrics/queries.go Show resolved Hide resolved
conversion/conversion.go Show resolved Hide resolved
conversion/conversion.go Outdated Show resolved Hide resolved
conversion/conversion.go Show resolved Hide resolved
internal/convert.go Outdated Show resolved Hide resolved
webv2/web.go Show resolved Hide resolved
common/metrics/metrics.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta asthamohta merged commit 118b375 into GoogleCloudPlatform:master Nov 20, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants