Adding regex check for handling failure in parsing dump files with specific syntax #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +114,10 @@ func readAndParseChunk(conv *internal.Conv, r *internal.Reader) ([]byte, []ast.S | |||
| n += copy(s[n:], l[i]) | |||
| } | |||
| chunk := string(s) | |||
| matchStatus := regexExp.Match([]byte(chunk)) | |||
| if matchStatus { | |||
There was a problem hiding this comment.
log that this is being skipped
| @@ -94,6 +94,10 @@ func processMySQLDump(conv *internal.Conv, r *internal.Reader) error { | |||
| // files containing tens or hundreds of GB of data. | |||
| func readAndParseChunk(conv *internal.Conv, r *internal.Reader) ([]byte, []ast.StmtNode, error) { | |||
| var l [][]byte | |||
|
|
|||
| // Regex for ignoring strings of the form /*!50717 SELECT COUNT(*) INTO @rocksdb_has_p_s_session_variables FROM INFORMATION_SCHEMA.TABLES */; | |||
| // These system generated SQL statements are currently not supported by parser and return error. | |||
There was a problem hiding this comment.
add reference to the bug in the comment
There was a problem hiding this comment.
added bug reference
There was a problem hiding this comment.
this check will slow down the parsing, but let's make optimizing the parsing an independent activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regex check filters out the system generated code of the format :
/!50717 SELECT COUNT() INTO @rocksdb_has_p_s_session_variables FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = 'performance_schema' AND TABLE_NAME = 'session_variables' */;
Such code format fails in parsing, we have added this regex as a workaround and will remove once pingcap provides a permanent fix for this : pingcap/parser#1370