Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing redundant updates of session file #1006

Merged

Conversation

VardhanThigle
Copy link
Collaborator

@VardhanThigle VardhanThigle commented Feb 5, 2025

Fixes b/394487678

  • Tests pass - Manually ran UI work flows for restore table, convert table, delete and add rules etc and checked that the file is flushed.
  • Appropriate changes to README are included in PR - NA

@VardhanThigle VardhanThigle changed the title [DRAFT] Fixing redundant updates of session file Fixing redundant updates of session file Feb 5, 2025
@VardhanThigle VardhanThigle marked this pull request as ready for review February 5, 2025 12:11
@VardhanThigle VardhanThigle requested a review from a team as a code owner February 5, 2025 12:11
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.76%. Comparing base (263e942) to head (c779f80).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
webv2/api/schema.go 0.00% 2 Missing ⚠️
webv2/api/rules.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   46.77%   46.76%   -0.02%     
==========================================
  Files         169      169              
  Lines       22950    22951       +1     
  Branches      563      563              
==========================================
- Hits        10734    10732       -2     
- Misses      11610    11613       +3     
  Partials      606      606              
Components Coverage Δ
backend-apis 46.18% <50.00%> (-0.01%) ⬇️
backend-library 52.91% <ø> (ø)
cli 4.85% <ø> (ø)
frontend 34.29% <ø> (-0.06%) ⬇️
Files with missing lines Coverage Δ
webv2/primarykey/primarykey_handler.go 86.95% <100.00%> (ø)
webv2/api/rules.go 41.84% <0.00%> (ø)
webv2/api/schema.go 63.58% <0.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VardhanThigle VardhanThigle merged commit ff09f97 into GoogleCloudPlatform:master Feb 5, 2025
10 checks passed
pratickchokhani pushed a commit to pratickchokhani/spanner-migration-tool that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants