Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Gemini Logging Setting from google-beta to google #13034

Merged

Conversation

PerlMonker303
Copy link
Contributor

@PerlMonker303 PerlMonker303 commented Feb 11, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Promote resources for Gemini Admin Control

`google_gemini_logging_setting` (ga)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 872 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 2 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 107 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample
  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample_update
    🟢 All tests passed!

View the build log

@PerlMonker303 PerlMonker303 marked this pull request as ready for review February 11, 2025 13:09
@github-actions github-actions bot requested a review from zli82016 February 11, 2025 13:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@zli82016
Copy link
Member

The tests passed in GA

  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample
  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample_update

@github-actions github-actions bot requested a review from zli82016 February 12, 2025 10:18
@zli82016
Copy link
Member

It looks like there is an conflict.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 889 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 4 insertions(+), 10 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample
  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample_update
    🟢 All tests passed!

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants