-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote Gemini Logging Setting from google-beta to google #13034
Promote Gemini Logging Setting from google-beta to google #13034
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 14 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
View the build log |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/third_party/terraform/services/gemini/resource_gemini_logging_setting_test.go.tmpl
Show resolved
Hide resolved
The tests passed in GA
|
It looks like there is an conflict. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 16 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
51f4dc0
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Promote resources for Gemini Admin Control