-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove concurrency on workflow_call github workflows #12998
remove concurrency on workflow_call github workflows #12998
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable but I also note that there are still builds being cancelled on this PR, which seems unexpected?
Also, what about the merge_group event - will that propagate correctly?
Yeah, I think the issue in general is with the concurrency field on workflow_call event types. I'm just going to remove this line. We should still get workflow cancelations from the top-level currency group |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/13204479522/job/36864303644?pr=12992
workflow_call
should inherit the full event payload from the calling workflow, includinggithub.event.pull_request
contextRelease Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.