Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove concurrency on workflow_call github workflows #12998

Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Feb 7, 2025

https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/13204479522/job/36864303644?pr=12992

  • The called workflow using workflow_call should inherit the full event payload from the calling workflow, including github.event.pull_request context
  • However, we're seeing the PR number missing from concurrency group names, suggesting this inheritance isn't working as expected
  • Added debug steps to inspect the available context in the called workflow
  • Removing concurrency on workfow call tasks and the parent workflow will capture this concurrency.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable but I also note that there are still builds being cancelled on this PR, which seems unexpected?

Also, what about the merge_group event - will that propagate correctly?

@ScottSuarez
Copy link
Contributor Author

ScottSuarez commented Feb 7, 2025

This seems reasonable but I also note that there are still builds being cancelled on this PR, which seems unexpected?

Also, what about the merge_group event - will that propagate correctly?

Yeah, I think the issue in general is with the concurrency field on workflow_call event types. I'm just going to remove this line. We should still get workflow cancelations from the top-level currency group

https://github.com/ScottSuarez/magic-modules/blob/a7e454214147d7b46b336fd8b76bfad6325e5a78/.github/workflows/downstreams.yml#L14

@ScottSuarez ScottSuarez added this pull request to the merge queue Feb 7, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 0915b2d Feb 7, 2025
11 checks passed
@ScottSuarez ScottSuarez changed the title log github event metadata to debug canceled workflow remove concurrency on workflow_call github workflows Feb 7, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants