-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location field to google_network_services_mesh #12991
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 58 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 58 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@@ -0,0 +1,98 @@ | |||
func resourceNetworkServicesMeshResourceV0() *schema.Resource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for adding this file here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding a StateUpgrader for the location
field for backward compatibility with existing resources / state files that don't have the field. Without this, the provider would substitute an empty value for {{location}}
in the URL during RUD operations for existing resources since there is no location
attribute in the state file, and it results in an error because the resource URL is invalid.
08ecbc9
Adds a new
location
field togoogle_network_services_mesh
.In the future, this will allow creating a regional Mesh resource, but currently regional Meshes are internal-only and not yet publicly available, so only the value
'global'
may be set. If omitted, the location defaults to'global'
.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.