Updated AlertPolicy resource to include sql condition types.

[haustenirving]

Fixes hashicorp/terraform-provider-google#21259.

Adds support for SQL condition types when creating an Alert Policy. SQL conditions are currently configurable through the UI or API directly: https://cloud.google.com/logging/docs/analyze/sql-in-alerting

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

monitoring: added `condition_sql` field to `monitoring_alert_policy` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 910 insertions(+))
google-beta provider: Diff ( 4 files changed, 910 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_alert_policy (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_alert_policy" "primary" {
  conditions {
    condition_sql {
      boolean_test {
        column = # value needed
      }
      daily {
        execution_time {
          hours   = # value needed
          minutes = # value needed
          nanos   = # value needed
          seconds = # value needed
        }
        periodicity = # value needed
      }
      hourly {
        minute_offset = # value needed
        periodicity   = # value needed
      }
      minutes {
        periodicity = # value needed
      }
      query = # value needed
      row_count_test {
        comparison = # value needed
        threshold  = # value needed
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 910 insertions(+))
google-beta provider: Diff ( 4 files changed, 910 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_alert_policy (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_alert_policy" "primary" {
  conditions {
    condition_sql {
      boolean_test {
        column = # value needed
      }
      daily {
        execution_time {
          hours   = # value needed
          minutes = # value needed
          nanos   = # value needed
          seconds = # value needed
        }
        periodicity = # value needed
      }
      hourly {
        minute_offset = # value needed
        periodicity   = # value needed
      }
      minutes {
        periodicity = # value needed
      }
      query = # value needed
      row_count_test {
        comparison = # value needed
        threshold  = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringAlertPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringAlertPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringAlertPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringAlertPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 911 insertions(+))
google-beta provider: Diff ( 4 files changed, 911 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_alert_policy (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_alert_policy" "primary" {
  conditions {
    condition_sql {
      boolean_test {
        column = # value needed
      }
      daily {
        execution_time {
          hours   = # value needed
          minutes = # value needed
          nanos   = # value needed
          seconds = # value needed
        }
        periodicity = # value needed
      }
      hourly {
        minute_offset = # value needed
        periodicity   = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringAlertPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringAlertPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[hao-nan-li]

Looks like this field is not expected here.

[haustenirving]

Yeah - duration isn't valid with SQL. I've updated the tests.

[hao-nan-li]

Could you also add the missing fields in the test?

[haustenirving]

Could you also add the missing fields in the test?

done.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1121 insertions(+))
google-beta provider: Diff ( 4 files changed, 1121 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringAlertPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringAlertPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1078 insertions(+))
google-beta provider: Diff ( 4 files changed, 1078 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringAlertPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringAlertPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1076 insertions(+))
google-beta provider: Diff ( 4 files changed, 1076 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringAlertPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringAlertPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1077 insertions(+))
google-beta provider: Diff ( 4 files changed, 1077 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 53
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• monitoring

🟢 All tests passed!

View the build log