Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding magic module config for osconfigv2 #12958

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darthmelonder
Copy link

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 8250 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 8250 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 2657 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 104 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_os_config_v2_policy_orchestrator (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_os_config_v2_policy_orchestrator" "primary" {
  action      = # value needed
  description = # value needed
  labels      = # value needed
  orchestrated_resource {
    id = # value needed
    os_policy_assignment_v1_payload {
      description = # value needed
      etag        = # value needed
      instance_filter {
        all = # value needed
        exclusion_labels {
          labels = # value needed
        }
        inclusion_labels {
          labels = # value needed
        }
        inventories {
          os_short_name = # value needed
          os_version    = # value needed
        }
      }
      name = # value needed
      os_policies {
        allow_no_resource_group_match = # value needed
        description                   = # value needed
        id                            = # value needed
        mode                          = # value needed
        resource_groups {
          inventory_filters {
            os_short_name = # value needed
            os_version    = # value needed
          }
          resources {
            exec {
              enforce {
                args = # value needed
                file {
                  allow_insecure = # value needed
                  gcs {
                    bucket     = # value needed
                    generation = # value needed
                    object     = # value needed
                  }
                  local_path = # value needed
                  remote {
                    sha256_checksum = # value needed
                    uri             = # value needed
                  }
                }
                interpreter      = # value needed
                output_file_path = # value needed
                script           = # value needed
              }
              validate {
                args = # value needed
                file {
                  allow_insecure = # value needed
                  gcs {
                    bucket     = # value needed
                    generation = # value needed
                    object     = # value needed
                  }
                  local_path = # value needed
                  remote {
                    sha256_checksum = # value needed
                    uri             = # value needed
                  }
                }
                interpreter      = # value needed
                output_file_path = # value needed
                script           = # value needed
              }
            }
            file {
              content = # value needed
              file {
                allow_insecure = # value needed
                gcs {
                  bucket     = # value needed
                  generation = # value needed
                  object     = # value needed
                }
                local_path = # value needed
                remote {
                  sha256_checksum = # value needed
                  uri             = # value needed
                }
              }
              path        = # value needed
              permissions = # value needed
              state       = # value needed
            }
            id = # value needed
            pkg {
              apt {
                name = # value needed
              }
              deb {
                pull_deps = # value needed
                source {
                  allow_insecure = # value needed
                  gcs {
                    bucket     = # value needed
                    generation = # value needed
                    object     = # value needed
                  }
                  local_path = # value needed
                  remote {
                    sha256_checksum = # value needed
                    uri             = # value needed
                  }
                }
              }
              desired_state = # value needed
              googet {
                name = # value needed
              }
              msi {
                properties = # value needed
                source {
                  allow_insecure = # value needed
                  gcs {
                    bucket     = # value needed
                    generation = # value needed
                    object     = # value needed
                  }
                  local_path = # value needed
                  remote {
                    sha256_checksum = # value needed
                    uri             = # value needed
                  }
                }
              }
              rpm {
                pull_deps = # value needed
                source {
                  allow_insecure = # value needed
                  gcs {
                    bucket     = # value needed
                    generation = # value needed
                    object     = # value needed
                  }
                  local_path = # value needed
                  remote {
                    sha256_checksum = # value needed
                    uri             = # value needed
                  }
                }
              }
              yum {
                name = # value needed
              }
              zypper {
                name = # value needed
              }
            }
            repository {
              apt {
                archive_type = # value needed
                components   = # value needed
                distribution = # value needed
                gpg_key      = # value needed
                uri          = # value needed
              }
              goo {
                name = # value needed
                url  = # value needed
              }
              yum {
                base_url     = # value needed
                display_name = # value needed
                gpg_keys     = # value needed
                id           = # value needed
              }
              zypper {
                base_url     = # value needed
                display_name = # value needed
                gpg_keys     = # value needed
                id           = # value needed
              }
            }
          }
        }
      }
      rollout {
        disruption_budget {
          fixed   = # value needed
          percent = # value needed
        }
        min_wait_duration = # value needed
      }
    }
  }
  orchestration_scope {
    selectors {
      location_selector {
        included_locations = # value needed
      }
      resource_hierarchy_selector {
        included_folders  = # value needed
        included_projects = # value needed
      }
    }
  }
  orchestration_state {
    current_iteration_state {
      error {
        code = # value needed
        details {
          type_url = # value needed
          value    = # value needed
        }
        message = # value needed
      }
    }
    previous_iteration_state {
      error {
        code = # value needed
        details {
          type_url = # value needed
          value    = # value needed
        }
        message = # value needed
      }
    }
  }
  policy_orchestrator_id = # value needed
  state                  = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4560
Passed tests: 4128
Skipped tests: 425
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccCloudbuildWorkerPool_basic
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample
  • TestAccOSConfigV2PolicyOrchestrator_osconfigv2PolicyOrchestratorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Error message] [Debug log]
TestAccOSConfigV2PolicyOrchestrator_osconfigv2PolicyOrchestratorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants