Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scope optional for google_compute_(region_)resize_request so that the default can be taken from the provider configuration #12957

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions mmv1/products/compute/RegionResizeRequest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,11 @@ parameters:
- name: 'region'
type: ResourceRef
description: |
The reference of the compute region scoping this request.
url_param_only: true
required: true
The reference of the compute region scoping this request. If it is not provided, the provider region is used.
custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
default_from_api: true
required: false
resource: 'Region'
imports: 'name'
- name: 'instanceGroupManager'
Expand Down
8 changes: 5 additions & 3 deletions mmv1/products/compute/ResizeRequest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,11 @@ parameters:
- name: 'zone'
type: ResourceRef
description: |
The reference of the compute zone scoping this request.
url_param_only: true
required: true
The reference of the compute zone scoping this request. If it is not provided, the provider zone is used.
custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
default_from_api: true
required: false
resource: 'Zone'
imports: 'name'
- name: 'instanceGroupManager'
Expand Down
Loading