Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scope optional for google_compute_(region_)resize_request so that the default can be taken from the provider configuration #12957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

askubis
Copy link
Member

@askubis askubis commented Feb 4, 2025

Makes it consistent with the other compute resources, especially in the instance_group_manager family.

compute: Allow google_compute_(region_)resize_request to not provide scope and use the provider default.

@github-actions github-actions bot requested a review from rileykarson February 4, 2025 09:49
Copy link

github-actions bot commented Feb 4, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 15 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 22 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1100
Passed tests: 1025
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants