Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GKE CPA tests so that cluster creation waits for CA creation. #12952

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

tonyzhc
Copy link
Contributor

@tonyzhc tonyzhc commented Feb 3, 2025

Fixes hashicorp/terraform-provider-google#20961.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions bot requested a review from melinath February 3, 2025 22:01
Copy link

github-actions bot commented Feb 3, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 225
Passed tests: 214
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change; looks like the tests are passing

@melinath melinath enabled auto-merge February 3, 2025 22:56
@melinath melinath added this pull request to the merge queue Feb 3, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 3fc0269 Feb 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccContainerCluster_WithCPAFeatures
3 participants