Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemini Data Sharing With Google Setting Binding resource #12906

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

PerlMonker303
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add new resources for Gemini Admin Control

`google_gemini_data_sharing_with_google_setting_binding`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from NickElliot January 29, 2025 09:25
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2025
@PerlMonker303
Copy link
Contributor Author

Currently failing because it depends on Gemini Data Sharing With Google Setting. Will fix after PR is submitted #12905.

Copy link

github-actions bot commented Feb 3, 2025

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2025
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending dependent pr

@github-actions github-actions bot requested a review from NickElliot February 4, 2025 09:21
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 159 insertions(+))
google-beta provider: Diff ( 5 files changed, 851 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_data_sharing_with_google_setting_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_data_sharing_with_google_setting_binding" "primary" {
  data_sharing_with_google_setting_id = # value needed
  labels                              = # value needed
  location                            = # value needed
  product                             = # value needed
  setting_binding_id                  = # value needed
  target                              = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiDataSharingWithGoogleSettingBinding_geminiDataSharingWithGoogleSettingBindingBasicExample_update
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 159 insertions(+))
google-beta provider: Diff ( 5 files changed, 851 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_data_sharing_with_google_setting_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_data_sharing_with_google_setting_binding" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiDataSharingWithGoogleSettingBinding_geminiDataSharingWithGoogleSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiDataSharingWithGoogleSettingBinding_geminiDataSharingWithGoogleSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants