Add Gemini Gemini Gcp Enablement Setting Binding resource #12897

PerlMonker303 · 2025-01-28T17:13:26Z

Release Note Template for Downstream PRs (will be copied)

Add new resources for Gemini Admin Control

`google_gemini_gemini_gcp_enablement_setting_binding`

github-actions · 2025-01-28T17:14:26Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-01-29T16:53:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 761 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 966 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting_binding (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting_binding" "primary" {
  labels  = # value needed
  product = # value needed
}

modular-magician · 2025-01-29T16:57:33Z

Tests analytics

Total tests: 9
Passed tests: 7
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample

TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

modular-magician · 2025-01-29T16:57:46Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

PerlMonker303 · 2025-01-29T17:57:51Z

Currently failing because it depends on Gemini Gemini Gcp Enablement Setting. Will fix after PR is submitted #12896.

github-actions · 2025-01-31T09:40:55Z

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

roaks3

Overall LGTM, but sounds like we need to wait for final approval until the other PR is merged

roaks3 · 2025-01-31T17:30:03Z

mmv1/products/gemini/GeminiGcpEnablementSettingBinding.yaml

+    vars:
+      gemini_gcp_enablement_setting_id: ls-tf1
+      setting_binding_id: ls-tf1b1
+      target: projects/980109375338


Can you describe what's going on with these hard-coded projects? If possible, the ideal would generally be to create temporary projects as part of the test config.

gemini_gcp_enablement_setting_id is used to identify a GeminiGcpEnablementSetting (see PR #12896). setting_binding_id is used to identify the setting binding (main resource of this PR).
A setting binding binds a setting to a target (org/project/...). In this case, we bind the created setting with id "ls-tf1b1" to a fixed project that has all permissions required to achieve this.

Can you suggest an example of a temporary project creation process? I could not find anything in the docs/examples.

roaks3 · 2025-01-31T17:30:38Z

mmv1/products/gemini/GeminiGcpEnablementSettingBinding.yaml

+    type: String
+    description: Required. Target of the binding.
+    required: true
+  - name: product


It looks like product isn't used in any tests (unless I missed it). Would be good to at least include it in the update test.

You are right. I added it now.

roaks3 · 2025-01-31T17:32:01Z

mmv1/templates/terraform/examples/gemini_gemini_gcp_enablement_setting_binding_basic.tf.tmpl

+    setting_binding_id = "{{index $.Vars "setting_binding_id"}}"
+    location = "global"
+    target = "{{index $.Vars "target"}}"
+    depends_on = [google_gemini_gemini_gcp_enablement_setting.basic]


If you can, it would be better to set gemini_gcp_enablement_setting_id to an output variable of google_gemini_gemini_gcp_enablement_setting.basic instead, which creates an implicit dependency

Good idea, thanks!

modular-magician · 2025-02-03T09:58:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 164 insertions(+))
google-beta provider: Diff ( 6 files changed, 969 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting_binding (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting_binding" "primary" {
  labels  = # value needed
  product = # value needed
}

modular-magician · 2025-02-03T10:02:08Z

Tests analytics

Total tests: 11
Passed tests: 9
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample

TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

modular-magician · 2025-02-03T10:02:21Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-03T10:27:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 165 insertions(+))
google-beta provider: Diff ( 6 files changed, 974 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting_binding" "primary" {
  labels = # value needed
}

modular-magician · 2025-02-03T10:31:47Z

Tests analytics

Total tests: 11
Passed tests: 9
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample_update

Get to know how VCR tests work

modular-magician · 2025-02-03T10:32:01Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-03T10:59:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 164 insertions(+))
google-beta provider: Diff ( 6 files changed, 970 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting_binding" "primary" {
  labels = # value needed
}

modular-magician · 2025-02-03T11:03:11Z

Tests analytics

Total tests: 11
Passed tests: 9
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample_update

Get to know how VCR tests work

modular-magician · 2025-02-03T11:03:25Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

PerlMonker303

Addressed feedback. Thank you for pointing these aspects out. They improve the quality of the code.

modular-magician · 2025-02-04T09:31:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 159 insertions(+))
google-beta provider: Diff ( 5 files changed, 851 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting_binding" "primary" {
  labels = # value needed
}

modular-magician · 2025-02-04T09:35:28Z

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample_update

Get to know how VCR tests work

modular-magician · 2025-02-04T09:35:42Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_geminiGeminiGcpEnablementSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Add Gemini Gemini Gcp Enablement Setting Binding resource

89b7466

github-actions bot requested a review from roaks3 January 28, 2025 17:14

Remove EOL

e7a1529

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2025

PerlMonker303 mentioned this pull request Jan 28, 2025

Add Gemini Gemini Gcp Enablement Setting Binding resource #12889

Closed

PerlMonker303 added 2 commits January 29, 2025 09:13

Remove project declaration

18860c7

Change copyright year

a17e474

modular-magician added service/gemini and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 29, 2025

roaks3 reviewed Jan 31, 2025

View reviewed changes

Mark resources as beta

c1af5ec

github-actions bot requested a review from roaks3 February 3, 2025 09:47

Specify product

1e27dc9

Remove depends_on

b7be68d

PerlMonker303 commented Feb 3, 2025

View reviewed changes

Exclude tests

094b781

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Gemini Gemini Gcp Enablement Setting Binding resource #12897

Add Gemini Gemini Gcp Enablement Setting Binding resource #12897

PerlMonker303 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

modular-magician commented Jan 29, 2025

modular-magician commented Jan 29, 2025

modular-magician commented Jan 29, 2025

PerlMonker303 commented Jan 29, 2025

github-actions bot commented Jan 31, 2025

roaks3 left a comment

roaks3 Jan 31, 2025

PerlMonker303 Feb 3, 2025

roaks3 Jan 31, 2025

PerlMonker303 Feb 3, 2025

roaks3 Jan 31, 2025

PerlMonker303 Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

PerlMonker303 left a comment

modular-magician commented Feb 4, 2025

modular-magician commented Feb 4, 2025

modular-magician commented Feb 4, 2025

Add Gemini Gemini Gcp Enablement Setting Binding resource #12897

Are you sure you want to change the base?

Add Gemini Gemini Gcp Enablement Setting Binding resource #12897

Conversation

PerlMonker303 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

modular-magician commented Jan 29, 2025

Diff report

Missing test report

modular-magician commented Jan 29, 2025

Tests analytics

Action taken

modular-magician commented Jan 29, 2025

PerlMonker303 commented Jan 29, 2025

github-actions bot commented Jan 31, 2025

roaks3 left a comment

Choose a reason for hiding this comment

roaks3 Jan 31, 2025

Choose a reason for hiding this comment

PerlMonker303 Feb 3, 2025

Choose a reason for hiding this comment

roaks3 Jan 31, 2025

Choose a reason for hiding this comment

PerlMonker303 Feb 3, 2025

Choose a reason for hiding this comment

roaks3 Jan 31, 2025

Choose a reason for hiding this comment

PerlMonker303 Feb 3, 2025

Choose a reason for hiding this comment

modular-magician commented Feb 3, 2025

Diff report

Missing test report

modular-magician commented Feb 3, 2025

Tests analytics

Action taken

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

Diff report

Missing test report

modular-magician commented Feb 3, 2025

Tests analytics

Action taken

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

Diff report

Missing test report

modular-magician commented Feb 3, 2025

Tests analytics

Action taken

modular-magician commented Feb 3, 2025

PerlMonker303 left a comment

Choose a reason for hiding this comment

modular-magician commented Feb 4, 2025

Diff report

Missing test report

modular-magician commented Feb 4, 2025

Tests analytics

Action taken

modular-magician commented Feb 4, 2025