From e89495c8946f0df68c8e208b9721cca19f8fa685 Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Tue, 28 Jan 2025 17:02:18 +0000 Subject: [PATCH 01/10] Add Gemini Release Channel Setting Binding resource --- .../gemini/ReleaseChannelSettingBinding.yaml | 105 ++++++++++++++++++ ...ease_channel_setting_binding_basic.tf.tmpl | 16 +++ ...lease_channel_setting_binding_test.go.tmpl | 98 ++++++++++++++++ 3 files changed, 219 insertions(+) create mode 100644 mmv1/products/gemini/ReleaseChannelSettingBinding.yaml create mode 100644 mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl create mode 100644 mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml new file mode 100644 index 000000000000..5cfff6b0adde --- /dev/null +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -0,0 +1,105 @@ +# Copyright 2024 Google Inc. +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +name: ReleaseChannelSettingBinding +description: The resource for managing ReleaseChannel setting bindings for Admin Control. +base_url: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings +self_link: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings/{{setting_binding_id}} +create_url: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings?settingBindingId={{setting_binding_id}} +id_format: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings/{{setting_binding_id}} +update_verb: PATCH +update_mask: true +import_format: + - projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings/{{setting_binding_id}} +mutex: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}} +examples: + - name: gemini_release_channel_setting_binding_basic + min_version: 'beta' + primary_resource_id: example + vars: + release_channel_setting_id: ls-tf1 + setting_binding_id: ls-tf1b1 + project_id: aandrei-test + target: projects/980109375338 +autogen_async: true +async: + operation: + timeouts: + insert_minutes: 90 + update_minutes: 90 + delete_minutes: 90 + base_url: '{{op_id}}' + actions: + - create + - delete + - update + type: OpAsync + result: + resource_inside_response: true + error: {} + include_project: false +autogen_status: U2V0dGluZ0JpbmRpbmdCeVByb2plY3RBbmRMb2NhdGlvbkFuZFJlbGVhc2VjaGFubmVsc2V0dGluZw== +parameters: + - name: location + type: String + description: Resource ID segment making up resource `name`. It identifies the resource within its parent collection as described in https://google.aip.dev/122. + immutable: true + url_param_only: true + required: true + - name: releaseChannelSettingId + type: String + description: Resource ID segment making up resource `name`. It identifies the resource within its parent collection as described in https://google.aip.dev/122. + immutable: true + url_param_only: true + required: true + - name: settingBindingId + type: String + description: |- + Required. Id of the requesting object. + If auto-generating Id server-side, remove this field and + setting_id from the method_signature of Create RPC. + immutable: true + url_param_only: true + required: true +properties: + - name: name + type: String + description: |- + Identifier. Name of the resource. + Format:projects/{project}/locations/{location}/{settingType}/{setting}/settingBindings/{setting_binding} + output: true + - name: createTime + type: String + description: Output only. [Output only] Create time stamp. + output: true + - name: updateTime + type: String + description: Output only. [Output only] Update time stamp. + output: true + - name: labels + type: KeyValueLabels + description: Optional. Labels as key value pairs. + - name: target + type: String + description: Required. Target of the binding. + required: true + - name: product + type: String + description: |- + Required. Product type of the setting binding. + Possible values: + PRODUCT_UNSPECIFIED + GEMINI_CLOUD_ASSIST + GEMINI_CODE_ASSIST + diff --git a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl new file mode 100644 index 000000000000..71e7e07093dc --- /dev/null +++ b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl @@ -0,0 +1,16 @@ +resource "google_gemini_release_channel_setting" "basic" { + provider = google-beta + release_channel_setting_id = "{{index $.Vars "release_channel_setting_id"}}" + location = "global" + project = "{{index $.Vars "project_id"}}" + release_channel = "EXPERIMENTAL" +} + +resource "google_gemini_release_channel_setting_binding" "{{$.PrimaryResourceId}}" { + provider = google-beta + release_channel_setting_id = "{{index $.Vars "release_channel_setting_id"}}" + setting_binding_id = "{{index $.Vars "setting_binding_id"}}" + location = "global" + target = "{{index $.Vars "target"}}" + depends_on = [google_gemini_release_channel_setting.basic] +} diff --git a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl new file mode 100644 index 000000000000..ee4f697c69f7 --- /dev/null +++ b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl @@ -0,0 +1,98 @@ +package gemini_test +{{- if ne $.TargetVersionName "ga" }} + +import ( + "testing" + + "github.com/hashicorp/terraform-plugin-testing/helper/resource" + "github.com/hashicorp/terraform-plugin-testing/plancheck" + + "github.com/hashicorp/terraform-provider-google/google/acctest" +) + +func TestAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindingBasicExample_update(t *testing.T) { + t.Parallel() + + context := map[string]interface{}{ + "release_channel_setting_id": "ls-tf1", + "setting_binding_id": "ls-tf1b1", + "project_id": "aandrei-test", + "target": "projects/980109375338", + "new_target": "projects/283661608541", + } + + acctest.VcrTest(t, resource.TestCase{ + PreCheck: func() { acctest.AccTestPreCheck(t) }, + ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t), + Steps: []resource.TestStep{ + { + Config: testAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindingBasicExample_basic(context), + }, + { + ResourceName: "google_gemini_release_channel_setting_binding.basic_binding", + ImportState: true, + ImportStateVerify: true, + ImportStateVerifyIgnore: []string{"labels", "location", "release_channel_setting_id", "terraform_labels"}, + }, + { + Config: testAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindingBasicExample_update(context), + ConfigPlanChecks: resource.ConfigPlanChecks{ + PreApply: []plancheck.PlanCheck{ + plancheck.ExpectResourceAction("google_gemini_release_channel_setting_binding.basic_binding", plancheck.ResourceActionUpdate), + }, + }, + }, + { + ResourceName: "google_gemini_release_channel_setting_binding.basic_binding", + ImportState: true, + ImportStateVerify: true, + ImportStateVerifyIgnore: []string{"labels", "location", "release_channel_setting_id", "terraform_labels"}, + }, + }, + }) +} + +func testAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindingBasicExample_basic(context map[string]interface{}) string { + return acctest.Nprintf(` +resource "google_gemini_release_channel_setting" "basic" { + provider = google-beta + release_channel_setting_id = "%{release_channel_setting_id}" + location = "global" + project = "%{project_id}" + release_channel = "EXPERIMENTAL" +} + +resource "google_gemini_release_channel_setting_binding" "basic_binding" { + provider = google-beta + release_channel_setting_id = "%{release_channel_setting_id}" + setting_binding_id = "%{setting_binding_id}" + location = "global" + project = "%{project_id}" + target = "%{target}" + depends_on = [google_gemini_release_channel_setting.basic] +} +`, context) +} + +func testAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindingBasicExample_update(context map[string]interface{}) string { + return acctest.Nprintf(` +resource "google_gemini_release_channel_setting" "basic" { + provider = google-beta + release_channel_setting_id = "%{release_channel_setting_id}" + location = "global" + project = "%{project_id}" + release_channel = "EXPERIMENTAL" +} + +resource "google_gemini_release_channel_setting_binding" "basic_binding" { + provider = google-beta + release_channel_setting_id = "%{release_channel_setting_id}" + setting_binding_id = "%{setting_binding_id}" + location = "global" + project = "%{project_id}" + target = "%{new_target}" + depends_on = [google_gemini_release_channel_setting.basic] +} +`, context) +} +{{ end }} From 373d035585570ca6303bb983f6de8a6211e685b8 Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Tue, 28 Jan 2025 17:08:19 +0000 Subject: [PATCH 02/10] Remove extra line --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index 5cfff6b0adde..a8bb7335156d 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -102,4 +102,3 @@ properties: PRODUCT_UNSPECIFIED GEMINI_CLOUD_ASSIST GEMINI_CODE_ASSIST - From 203554c5ec8d3fc93c51ab7c6f94c9c29857e4a1 Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Wed, 29 Jan 2025 09:04:29 +0000 Subject: [PATCH 03/10] Remove project declaration --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 1 - .../gemini_release_channel_setting_binding_basic.tf.tmpl | 1 - ...ource_gemini_release_channel_setting_binding_test.go.tmpl | 5 ----- 3 files changed, 7 deletions(-) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index a8bb7335156d..8ef46c3a2e6a 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -30,7 +30,6 @@ examples: vars: release_channel_setting_id: ls-tf1 setting_binding_id: ls-tf1b1 - project_id: aandrei-test target: projects/980109375338 autogen_async: true async: diff --git a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl index 71e7e07093dc..9899628720da 100644 --- a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl +++ b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl @@ -2,7 +2,6 @@ resource "google_gemini_release_channel_setting" "basic" { provider = google-beta release_channel_setting_id = "{{index $.Vars "release_channel_setting_id"}}" location = "global" - project = "{{index $.Vars "project_id"}}" release_channel = "EXPERIMENTAL" } diff --git a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl index ee4f697c69f7..c478e01bcc9f 100644 --- a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl +++ b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl @@ -16,7 +16,6 @@ func TestAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindin context := map[string]interface{}{ "release_channel_setting_id": "ls-tf1", "setting_binding_id": "ls-tf1b1", - "project_id": "aandrei-test", "target": "projects/980109375338", "new_target": "projects/283661608541", } @@ -58,7 +57,6 @@ resource "google_gemini_release_channel_setting" "basic" { provider = google-beta release_channel_setting_id = "%{release_channel_setting_id}" location = "global" - project = "%{project_id}" release_channel = "EXPERIMENTAL" } @@ -67,7 +65,6 @@ resource "google_gemini_release_channel_setting_binding" "basic_binding" { release_channel_setting_id = "%{release_channel_setting_id}" setting_binding_id = "%{setting_binding_id}" location = "global" - project = "%{project_id}" target = "%{target}" depends_on = [google_gemini_release_channel_setting.basic] } @@ -80,7 +77,6 @@ resource "google_gemini_release_channel_setting" "basic" { provider = google-beta release_channel_setting_id = "%{release_channel_setting_id}" location = "global" - project = "%{project_id}" release_channel = "EXPERIMENTAL" } @@ -89,7 +85,6 @@ resource "google_gemini_release_channel_setting_binding" "basic_binding" { release_channel_setting_id = "%{release_channel_setting_id}" setting_binding_id = "%{setting_binding_id}" location = "global" - project = "%{project_id}" target = "%{new_target}" depends_on = [google_gemini_release_channel_setting.basic] } From 24ceadf562d48acf24c815545103bad13025c822 Mon Sep 17 00:00:00 2001 From: "Stephen Lewis (Burrows)" Date: Wed, 29 Jan 2025 08:25:40 -0800 Subject: [PATCH 04/10] Update mmv1/products/gemini/ReleaseChannelSettingBinding.yaml --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index 8ef46c3a2e6a..d18d1ab01c76 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -1,4 +1,4 @@ -# Copyright 2024 Google Inc. +# Copyright 2025 Google Inc. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at From 94894a0c22f51c63ac96d5e169ae519df8e9bded Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Wed, 29 Jan 2025 16:40:43 +0000 Subject: [PATCH 05/10] Remove errors field --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index d18d1ab01c76..9809d61ccb1f 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -46,7 +46,6 @@ async: type: OpAsync result: resource_inside_response: true - error: {} include_project: false autogen_status: U2V0dGluZ0JpbmRpbmdCeVByb2plY3RBbmRMb2NhdGlvbkFuZFJlbGVhc2VjaGFubmVsc2V0dGluZw== parameters: From 909e8350fe0c002d275350a933691e8f76ca2cfd Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Mon, 3 Feb 2025 09:45:32 +0000 Subject: [PATCH 06/10] Mark resources as beta --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index 9809d61ccb1f..adda9e693c35 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -14,6 +14,7 @@ --- name: ReleaseChannelSettingBinding description: The resource for managing ReleaseChannel setting bindings for Admin Control. +min_version: 'beta' base_url: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings self_link: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings/{{setting_binding_id}} create_url: projects/{{project}}/locations/{{location}}/releaseChannelSettings/{{release_channel_setting_id}}/settingBindings?settingBindingId={{setting_binding_id}} From 61dbb2c93c15eb83f3d3835c4f92a350baa162f5 Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Mon, 3 Feb 2025 10:59:50 +0000 Subject: [PATCH 07/10] Remove resource dependency --- .../gemini_release_channel_setting_binding_basic.tf.tmpl | 3 +-- ...rce_gemini_release_channel_setting_binding_test.go.tmpl | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl index 9899628720da..f09683090cae 100644 --- a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl +++ b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl @@ -7,9 +7,8 @@ resource "google_gemini_release_channel_setting" "basic" { resource "google_gemini_release_channel_setting_binding" "{{$.PrimaryResourceId}}" { provider = google-beta - release_channel_setting_id = "{{index $.Vars "release_channel_setting_id"}}" + release_channel_setting_id = google_gemini_release_channel_setting.basic.release_channel_setting_id setting_binding_id = "{{index $.Vars "setting_binding_id"}}" location = "global" target = "{{index $.Vars "target"}}" - depends_on = [google_gemini_release_channel_setting.basic] } diff --git a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl index c478e01bcc9f..f3d34aafa02a 100644 --- a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl +++ b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl @@ -16,6 +16,7 @@ func TestAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindin context := map[string]interface{}{ "release_channel_setting_id": "ls-tf1", "setting_binding_id": "ls-tf1b1", + "product": "PRODUCT_UNSPECIFIED" "target": "projects/980109375338", "new_target": "projects/283661608541", } @@ -62,11 +63,10 @@ resource "google_gemini_release_channel_setting" "basic" { resource "google_gemini_release_channel_setting_binding" "basic_binding" { provider = google-beta - release_channel_setting_id = "%{release_channel_setting_id}" + release_channel_setting_id = google_gemini_release_channel_setting.basic.release_channel_setting_id setting_binding_id = "%{setting_binding_id}" location = "global" target = "%{target}" - depends_on = [google_gemini_release_channel_setting.basic] } `, context) } @@ -82,11 +82,10 @@ resource "google_gemini_release_channel_setting" "basic" { resource "google_gemini_release_channel_setting_binding" "basic_binding" { provider = google-beta - release_channel_setting_id = "%{release_channel_setting_id}" + release_channel_setting_id = google_gemini_release_channel_setting.basic.release_channel_setting_id setting_binding_id = "%{setting_binding_id}" location = "global" target = "%{new_target}" - depends_on = [google_gemini_release_channel_setting.basic] } `, context) } From 30b03766c482479a92371fc69cb0adb72dcdaa84 Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Mon, 3 Feb 2025 11:03:29 +0000 Subject: [PATCH 08/10] Add product specification --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 1 + .../gemini_release_channel_setting_binding_basic.tf.tmpl | 1 + ...resource_gemini_release_channel_setting_binding_test.go.tmpl | 2 ++ 3 files changed, 4 insertions(+) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index adda9e693c35..914a73669250 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -32,6 +32,7 @@ examples: release_channel_setting_id: ls-tf1 setting_binding_id: ls-tf1b1 target: projects/980109375338 + product: PRODUCT_UNSPECIFIED autogen_async: true async: operation: diff --git a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl index f09683090cae..b319e89494e7 100644 --- a/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl +++ b/mmv1/templates/terraform/examples/gemini_release_channel_setting_binding_basic.tf.tmpl @@ -11,4 +11,5 @@ resource "google_gemini_release_channel_setting_binding" "{{$.PrimaryResourceId} setting_binding_id = "{{index $.Vars "setting_binding_id"}}" location = "global" target = "{{index $.Vars "target"}}" + product = "{{index $.Vars "product"}}" } diff --git a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl index f3d34aafa02a..bd016e68abd6 100644 --- a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl +++ b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl @@ -67,6 +67,7 @@ resource "google_gemini_release_channel_setting_binding" "basic_binding" { setting_binding_id = "%{setting_binding_id}" location = "global" target = "%{target}" + product = "%{product}" } `, context) } @@ -86,6 +87,7 @@ resource "google_gemini_release_channel_setting_binding" "basic_binding" { setting_binding_id = "%{setting_binding_id}" location = "global" target = "%{new_target}" + product = "%{product}" } `, context) } From 6e726f976037fad84c2bd3bc65375593f1c962dc Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Mon, 3 Feb 2025 11:32:56 +0000 Subject: [PATCH 09/10] Add missing comma --- ...resource_gemini_release_channel_setting_binding_test.go.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl index bd016e68abd6..d1b612cb6504 100644 --- a/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl +++ b/mmv1/third_party/terraform/services/gemini/resource_gemini_release_channel_setting_binding_test.go.tmpl @@ -16,7 +16,7 @@ func TestAccGeminiReleaseChannelSettingBinding_geminiReleaseChannelSettingBindin context := map[string]interface{}{ "release_channel_setting_id": "ls-tf1", "setting_binding_id": "ls-tf1b1", - "product": "PRODUCT_UNSPECIFIED" + "product": "PRODUCT_UNSPECIFIED", "target": "projects/980109375338", "new_target": "projects/283661608541", } From 184ef672e44fe29fd9429a8d45e36b05f2b193ee Mon Sep 17 00:00:00 2001 From: Andrei-Robert Alexandrescu Date: Tue, 4 Feb 2025 09:18:57 +0000 Subject: [PATCH 10/10] Exclude tests --- mmv1/products/gemini/ReleaseChannelSettingBinding.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml index 914a73669250..4a1c2b25772d 100644 --- a/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml +++ b/mmv1/products/gemini/ReleaseChannelSettingBinding.yaml @@ -28,6 +28,7 @@ examples: - name: gemini_release_channel_setting_binding_basic min_version: 'beta' primary_resource_id: example + exclude_test: true vars: release_channel_setting_id: ls-tf1 setting_binding_id: ls-tf1b1