Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemini Logging Setting Binding resource #12893

Open
wants to merge 136 commits into
base: main
Choose a base branch
from

Conversation

PerlMonker303
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add new resources for Gemini Admin Control

`google_gemini_logging_setting_binding`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2025
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 761 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 966 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels  = # value needed
  product = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 7
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@PerlMonker303
Copy link
Contributor Author

Currently failing because it depends on Gemini Logging Setting. Will fix after PR is submitted #12892.

Copy link

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just want to see the test passing now that the blocking PR is merged. Thanks!

melinath and others added 13 commits February 3, 2025 09:32
@github-actions github-actions bot requested a review from SirGitsalot February 3, 2025 09:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 168 insertions(+), 701 deletions(-))
google-beta provider: Diff ( 7 files changed, 971 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_gemini_logging_setting was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels  = # value needed
  product = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 9
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 168 insertions(+), 701 deletions(-))
google-beta provider: Diff ( 7 files changed, 972 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_gemini_logging_setting was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • gemini

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update
  • TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiLoggingSetting_geminiLoggingSettingBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 168 insertions(+), 701 deletions(-))
google-beta provider: Diff ( 7 files changed, 972 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_gemini_logging_setting was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 9
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • gemini

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample [Error message] [Debug log]
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment with a one-line fix to get the tests green, otherwise LGTM!

@github-actions github-actions bot requested a review from SirGitsalot February 4, 2025 09:17
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 163 insertions(+), 702 deletions(-))
google-beta provider: Diff ( 6 files changed, 853 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_gemini_logging_setting was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 163 insertions(+), 702 deletions(-))
google-beta provider: Diff ( 6 files changed, 873 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_gemini_logging_setting was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_logging_setting_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_logging_setting_binding" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiLoggingSettingBinding_geminiLoggingSettingBindingBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.