Add Gemini Logging Setting Binding resource #12885
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
| - name: logPromptsAndResponses | ||
| type: Boolean | ||
| description: Optional. Whether to log prompts and responses. | ||
| - name: slogMetadata |
There was a problem hiding this comment.
slogMetadata?
Can you add a test for this to make sure it's correct
There was a problem hiding this comment.
Good catch, it should be logMetadata. Added field in tests.
| vars: | ||
| logging_setting_id: ls-tf1 | ||
| setting_binding_id: ls-tf1b1 | ||
| project_id: aandrei-test |
There was a problem hiding this comment.
These need to target resources within the environment
| provider = google-beta | ||
| logging_setting_id = "%{logging_setting_id}" | ||
| setting_binding_id = "%{setting_binding_id}" | ||
| location = "global" |
There was a problem hiding this comment.
Spacing is off in this file
| provider = google-beta | ||
| logging_setting_id = "%{setting_id}" | ||
| location = "global" | ||
| project = "%{project_id}" |
|
Created a new PR #12893. We can close this one. |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Add new resources for Gemini Admin Control