Add labels property to HA VPN Gateway

[cynicphoenix]

compute: added `labels` field to `ha_vpn_gateway` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1097
Passed tests: 1005
Skipped tests: 75
Affected tests: 17

Click here to see the affected service packages

• compute

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_haVpnGatewayBasicExample
• TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example
• TestAccComputeRouterInterface_withTunnel
• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeRouterPeer_EnableDisableIpv6
• TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
• TestAccComputeRouterPeer_Ipv6Basic
• TestAccComputeRouterPeer_UpdateIpv6Address
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeRouterPeer_addImportAndExportPolicy
• TestAccComputeRouterPeer_advertiseMode
• TestAccComputeRouterPeer_basic
• TestAccComputeRouterPeer_bfd
• TestAccComputeRouterPeer_enable
• TestAccComputeVpnTunnel_router
• TestAccDataSourceComputeHaVpnGateway
• TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 1097
Passed tests: 1005
Skipped tests: 75
Affected tests: 17

Click here to see the affected service packages

• compute

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_haVpnGatewayBasicExample
• TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example
• TestAccComputeRouterInterface_withTunnel
• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeRouterPeer_EnableDisableIpv6
• TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
• TestAccComputeRouterPeer_Ipv6Basic
• TestAccComputeRouterPeer_UpdateIpv6Address
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeRouterPeer_addImportAndExportPolicy
• TestAccComputeRouterPeer_advertiseMode
• TestAccComputeRouterPeer_basic
• TestAccComputeRouterPeer_bfd
• TestAccComputeRouterPeer_enable
• TestAccComputeVpnTunnel_router
• TestAccDataSourceComputeHaVpnGateway
• TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeVpnTunnel_router [Debug log]
TestAccDataSourceComputeHaVpnGateway [Debug log]
TestAccDataSourceComputeRouterStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeVpnTunnel_router [Debug log]
TestAccDataSourceComputeHaVpnGateway [Debug log]
TestAccDataSourceComputeRouterStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[harshithpatte-g]

@cynicphoenix if label fields are mutable, can we add update tests?

[modular-magician]

Tests analytics

Total tests: 1097
Passed tests: 1022
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 296 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 296 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeHaVpnGateway_updateLabels
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 293 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 293 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeHaVpnGateway_updateLabels
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 294 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 294 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1098
Passed tests: 1022
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_updateLabels

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

Please rename the test file to resource_compute_ha_vpn_gateway_test.go

[cynicphoenix]

Renamed,

[shuyama1]

Test failed with the following error:

resource_compute_ha_vpn_gateway_labels_test.go:19: Step 1/4 error: Error running pre-apply refresh: exit status 1
        
        Error: Reference to undeclared resource
        
          on terraform_plugin_test.tf line 5, in resource "google_compute_ha_vpn_gateway" "ha_gateway1":
           5:   network  = google_compute_network.network1.id
        
        A managed resource "google_compute_network" "network1" has not been declared
        in the root module.

You'll need to create a dependent resource google_compute_network inline so it can be referenced. Please see the generated tests as examples. https://github.com/hashicorp/terraform-provider-google-beta/blob/main/google-beta/services/compute/resource_compute_ha_vpn_gateway_generated_test.go#L66

[cynicphoenix]

Added network resource

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 317 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 317 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1101
Passed tests: 1025
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_updateLabels

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 300 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 300 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeHaVpnGateway_updateLabels
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 300 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 300 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1101
Passed tests: 1025
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_updateLabels

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 300 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 300 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1101
Passed tests: 1025
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_updateLabels

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 310 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 310 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeHaVpnGateway_updateLabels
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 305 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 305 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeHaVpnGateway_updateLabels
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 306 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 306 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1101
Passed tests: 1025
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_updateLabels

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 366 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 366 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1101
Passed tests: 1008
Skipped tests: 75
Affected tests: 18

Click here to see the affected service packages

• compute

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeHaVpnGateway_haVpnGatewayBasicExample
• TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example
• TestAccComputeHaVpnGateway_updateLabels
• TestAccComputeRouterInterface_withTunnel
• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeRouterPeer_EnableDisableIpv6
• TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
• TestAccComputeRouterPeer_Ipv6Basic
• TestAccComputeRouterPeer_UpdateIpv6Address
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeRouterPeer_addImportAndExportPolicy
• TestAccComputeRouterPeer_advertiseMode
• TestAccComputeRouterPeer_basic
• TestAccComputeRouterPeer_bfd
• TestAccComputeRouterPeer_enable
• TestAccComputeVpnTunnel_router
• TestAccDataSourceComputeHaVpnGateway
• TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample [Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example [Debug log]
TestAccComputeRouterInterface_withTunnel [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6 [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate [Debug log]
TestAccComputeRouterPeer_Ipv6Basic [Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_addImportAndExportPolicy [Debug log]
TestAccComputeRouterPeer_advertiseMode [Debug log]
TestAccComputeRouterPeer_basic [Debug log]
TestAccComputeRouterPeer_bfd [Debug log]
TestAccComputeRouterPeer_enable [Debug log]
TestAccComputeVpnTunnel_router [Debug log]
TestAccDataSourceComputeHaVpnGateway [Debug log]
TestAccDataSourceComputeRouterStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeHaVpnGateway_updateLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test