Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc to test merging unit test and vcr test #12815

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iyabchen
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • apigee

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 16
Skipped tests: 36
Affected tests: 2

Click here to see the affected service packages
  • apigee

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 16
Skipped tests: 36
Affected tests: 2

Click here to see the affected service packages
  • apigee

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 1 file changed, 32 insertions(+), 49 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 17
Skipped tests: 36
Affected tests: 1

Click here to see the affected service packages
  • apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1096
Passed tests: 1020
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1096
Passed tests: 1020
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1096
Passed tests: 1020
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1096
Passed tests: 1020
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1096
Passed tests: 1019
Skipped tests: 75
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1100
Passed tests: 1024
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute		coverage: 66.6% of statements

Here's the [coverate details](https://storage.cloud.google.com/test-coverage-data/cov/%!s(MISSING)/profile.htmlb104d147-2406-489c-a2c1-9c7313d44d41

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1100
Passed tests: 1024
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute		coverage: 66.6% of statements

Here's the [coverate details](https://storage.cloud.google.com/test-coverage-data/cov/ddf603d5-e2a2-4d71-81f8-f6d0e7f6f370/profile.html

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field disk_encryption_key.raw_key within resource google_compute_region_disk was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_disk (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_disk" "primary" {
  disk_encryption_key {
    raw_key_ichen = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1100
Passed tests: 1024
Skipped tests: 75
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_encryption

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionDisk_encryption [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute		coverage: 66.6% of statements

Here's the coverate details

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Here's the coverate details

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Here's the coverate details

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Here's the coverate details

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1101
Passed tests: 1026
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute		coverage: 66.7% of statements

Here's the coverate details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants