Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network peering routes config updates #12581

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brcabrera
Copy link

@brcabrera brcabrera commented Dec 16, 2024

This PR adds the import_subnet_routes_with_public_ip and export_subnet_routes_with_public_ip fields to the compute resource google_compute_network_peering_routes_config.

Fixes: hashicorp/terraform-provider-google#11573

Although there is an API side default, I set these fields as required without defaults as people may have this resource already in state, and it is undesirable to change without explicitly choosing to.

This mirrors the approach of import_custom_routes and export_custom_routes. Please let me know if there is a better approach.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `import_subnet_routes_with_public_ip` and `export_subnet_routes_with_public_ip` fields to `google_compute_network_peering_routes_config` resource

Copy link

google-cla bot commented Dec 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson December 16, 2024 17:31
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 16, 2024
@brcabrera brcabrera closed this Dec 16, 2024
@brcabrera brcabrera reopened this Dec 16, 2024
@brcabrera brcabrera closed this Dec 16, 2024
@brcabrera brcabrera reopened this Dec 16, 2024
@brcabrera brcabrera closed this Dec 16, 2024
@brcabrera brcabrera reopened this Dec 16, 2024
@brcabrera brcabrera closed this Dec 16, 2024
@brcabrera brcabrera reopened this Dec 16, 2024
@brcabrera brcabrera closed this Dec 16, 2024
@brcabrera brcabrera reopened this Dec 16, 2024
@brcabrera brcabrera closed this Dec 16, 2024
@brcabrera brcabrera reopened this Dec 16, 2024
Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@brcabrera
Copy link
Author

@rileykarson can you please review this PR?

Copy link

github-actions bot commented Jan 6, 2025

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/compute-network-peering and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 7, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 90 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 3 files changed, 90 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1077
Passed tests: 1003
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@brcabrera brcabrera requested a review from rileykarson February 3, 2025 19:57
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-network-peering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the fields to google_compute_network_peering_routes_config
3 participants