Skip to content

Commit

Permalink
Update cluster versions in TestAccContainerNodePool_concurrent
Browse files Browse the repository at this point in the history
At time of this writing, the cluster default version is 1.31.5,
so the API will not update such as cluster to 1.29.4.

This change does not "fix" the need to update these static versions
from time to time. It does leave breadcrumbs for the next traveler
to zero in on the answer.
  • Loading branch information
bbasata committed Feb 4, 2025
1 parent cca64da commit 457d9b9
Showing 1 changed file with 14 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3960,13 +3960,17 @@ resource "google_container_node_pool" "np1" {
location = "us-central1-a"
cluster = google_container_cluster.cluster.name
initial_node_count = 2
// 2025-02-03: current default cluster version is 1.31.5-gke.1023000. This will change over time.
// Reference: https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions
}

resource "google_container_node_pool" "np2" {
name = "%s"
location = "us-central1-a"
cluster = google_container_cluster.cluster.name
initial_node_count = 2
// 2025-02-03: current default cluster version is 1.31.5-gke.1023000. This will change over time.
// Reference: https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions
}
`, cluster, networkName, subnetworkName, np1, np2)
}
Expand All @@ -3987,15 +3991,23 @@ resource "google_container_node_pool" "np1" {
location = "us-central1-a"
cluster = google_container_cluster.cluster.name
initial_node_count = 2
version = "1.29.4-gke.1043002"
version = "1.32.0-gke.1448000"
// This must remain within one minor version of the default cluster version
// Cross-ref: https://github.com/hashicorp/terraform-provider-google/issues/21116
// Cross-ref: https://github.com/GoogleCloudPlatform/magic-modules/pull/11115
// Reference: https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions
}

resource "google_container_node_pool" "np2" {
name = "%s"
location = "us-central1-a"
cluster = google_container_cluster.cluster.name
initial_node_count = 2
version = "1.29.4-gke.1043002"
version = "1.32.0-gke.1448000"
// This must remain within one minor version of the default cluster version
// Cross-ref: https://github.com/hashicorp/terraform-provider-google/issues/21116
// Cross-ref: https://github.com/GoogleCloudPlatform/magic-modules/pull/11115
// Reference: https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions
}
`, cluster, networkName, subnetworkName, np1, np2)
}
Expand Down

0 comments on commit 457d9b9

Please sign in to comment.