Small UX improvements #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abdolence
commented
Dec 7, 2023
abdolence
commented
- Human predictable sorting for Project IDs and roles.
- Adjusting UI stepper width when custom roles are used
abdolence
force-pushed
the
feature/ui-improvements
branch
from
23cf1df to
fd8c339
Compare
jpassing
reviewed
Dec 8, 2023
sources/src/main/java/com/google/solutions/jitaccess/core/adapters/ResourceManagerAdapter.java
Show resolved
Hide resolved
sources/src/main/java/com/google/solutions/jitaccess/core/services/RoleDiscoveryService.java
Outdated
Show resolved
Hide resolved
sources/src/main/java/com/google/solutions/jitaccess/core/services/RoleDiscoveryService.java
Show resolved
Hide resolved
|
@jpassing Sorry for confusion with TreeSet without Comparable. Updated the PR with tests as well to cover this. |
abdolence
force-pushed
the
feature/ui-improvements
branch
from
1922c3b to
9bf517b
Compare
jpassing
reviewed
Dec 11, 2023
sources/src/main/java/com/google/solutions/jitaccess/core/services/RoleDiscoveryService.java
Show resolved
Hide resolved
jpassing
reviewed
Dec 12, 2023
sources/src/main/java/com/google/solutions/jitaccess/core/services/RoleDiscoveryService.java
Outdated
Show resolved
Hide resolved
|
Looks good now:
Thanks for creating this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.