Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into starting hydra with https using self certified tls #2113

Open
zohrehj opened this issue Nov 21, 2020 · 3 comments
Open

Look into starting hydra with https using self certified tls #2113

zohrehj opened this issue Nov 21, 2020 · 3 comments
Assignees
Labels
Hydra Issues related to the `Hydra` component P3 Lower priority issue (should be done, but with no specific urgency) Tech debt Technical work that should be addressed when possible
Milestone

Comments

@zohrehj
Copy link
Contributor

zohrehj commented Nov 21, 2020

With the current setup we need to use --dangerous-use-http flag to enable calling hydra using http calls at cluster level and with the admin endpoint. The problem with this approach is that cookies set by hydra are not secure.

@zohrehj zohrehj added Deployment This issue is related to deploying the platform Security bug Tech debt Technical work that should be addressed when possible labels Nov 21, 2020
@dhanyak-btc dhanyak-btc self-assigned this Nov 23, 2020
@dhanyak-btc
Copy link
Contributor

@zohrehj I setup the hydra with self signed certificate, cookies set by hydra are secure. We should use https in production environment. Please refer Preparing for Production. I copied below text from hydra documentation.

If you are unable to properly set up TLS Termination, you may want to set the --dangerous-force-http flag. But please be aware that we discourage you from doing so and that you should know what you're doing.

@zohrehj
Copy link
Contributor Author

zohrehj commented Nov 24, 2020

our deployment uses ingress + google managed Certificates.
There is no tls certificate etc at Hydra level, so we run it with the flag.
That in turn causes only http requests to be served and for hydra cookies to be marked as insecure.

One alternative is to incorporate a self certified certificate into the hydra initial setup and remove the flag; but it requires more investigation and testing.

It is not a blocking issue, but we should look into it at some point.

@jkrogers18 jkrogers18 removed Deployment This issue is related to deploying the platform Security bug labels Dec 16, 2020
@jkrogers18 jkrogers18 added P3 Lower priority issue (should be done, but with no specific urgency) Hydra Issues related to the `Hydra` component labels Dec 16, 2020
@jkrogers18 jkrogers18 added this to the Backlog milestone Dec 16, 2020
@dhanyak-btc
Copy link
Contributor

@mohangmk Please refer Hydra Configuration to configure self-signed certificate.

	-e SERVE_TLS_KEY_PATH="/home/ssl/key.pem"
	-e SERVE_TLS_CERT_PATH="/home/ssl/hydra.crt"

@dhanyak-btc dhanyak-btc modified the milestones: Backlog, v2.0.3 Feb 5, 2021
@aswinijena100 aswinijena100 modified the milestones: v2.0.3, v2.0.4 Feb 26, 2021
@madhurya-btc madhurya-btc modified the milestones: v2.0.4, v2.0.5 Apr 7, 2021
@aswinijena100 aswinijena100 modified the milestones: v2.0.5, 2.0.6 May 4, 2021
@SR-btc SR-btc modified the milestones: v2.0.6, v2.0.7 Jun 9, 2021
@aswinijena100 aswinijena100 modified the milestones: v2.0.7, v2.0.8 Jul 20, 2021
@mohangmk mohangmk removed their assignment Jul 20, 2021
@aswinijena100 aswinijena100 removed their assignment Jul 20, 2021
@aswinijena100 aswinijena100 modified the milestones: v2.0.8, v2.0.9 Sep 23, 2021
@madhurya-btc madhurya-btc modified the milestones: v2.0.9, v2.0.10 Dec 15, 2021
@aswinijena100 aswinijena100 modified the milestones: v2.0.10, Backlog Jan 18, 2022
@mohangmk mohangmk removed their assignment Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hydra Issues related to the `Hydra` component P3 Lower priority issue (should be done, but with no specific urgency) Tech debt Technical work that should be addressed when possible
Projects
None yet
Development

No branches or pull requests

10 participants