Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Regression in develop branch #945

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Fix: Regression in develop branch #945

merged 3 commits into from
Feb 7, 2025

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Feb 7, 2025

Description

This PR aims to fix regression in the develop branch.

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run build:ext.
  • In the browser, go to example.com.
  • Navigate to DevTools, go to PSAT extension and then navigate to Protected Audience tab.
  • Now in the Explorable Explanations.
  • In full speed check the following things.

Checklist:

  • In advertiser the flow, try going to auction in the below table. It should not break.
  • Check the multi-seller flow and then reload frame, it should not be buggy when starting.
  • The multi-seller auction data should be seen in the table.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 changed the base branch from main to develop February 7, 2025 09:25
@amovar18 amovar18 self-assigned this Feb 7, 2025
@amovar18 amovar18 marked this pull request as ready for review February 7, 2025 11:15
@amovar18 amovar18 requested review from mayan-000 and mohdsayed and removed request for mayan-000 February 7, 2025 11:15
@amovar18 amovar18 added this to the v0.13.0 milestone Feb 7, 2025
@mohdsayed mohdsayed merged commit ec5d2da into develop Feb 7, 2025
1 check passed
@mohdsayed mohdsayed deleted the fix/regression branch February 7, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants