Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Clear ripple effect marking #928

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix: Clear ripple effect marking #928

merged 1 commit into from
Jan 29, 2025

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Jan 29, 2025 •
edited by mohdsayed
Loading

Description

  • This PR adds code to clean up the marking left behind by the ripple effect if paused for long.
  • Clean the ripple area on timeout.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Screen.Recording.2025-01-29.at.19.13.17.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mayan-000 mayan-000 added this to the v1.0 milestone Jan 29, 2025
@mayan-000 mayan-000 self-assigned this Jan 29, 2025
@mayan-000 mayan-000 requested a review from mohdsayed January 29, 2025 13:44
@mayan-000 mayan-000 marked this pull request as ready for review January 29, 2025 13:44
@mayan-000 mayan-000 changed the title Fix: Ripple effect marking Fix: Clear ripple effect marking Jan 29, 2025
@mohdsayed mohdsayed added the bug Something isn't working label Jan 29, 2025
@mohdsayed mohdsayed merged commit de172a3 into develop Jan 29, 2025
6 checks passed
@mohdsayed mohdsayed deleted the fix/ripple-effect branch January 29, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mayan-000 @mohdsayed